Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ✨ Add module importing #94

Closed
wants to merge 3 commits into from
Closed

Conversation

0fatih
Copy link

@0fatih 0fatih commented Aug 5, 2023

Closes #26

What does this PR do?

This PR adds the documentation for how to import new modules to App.

Please let me know if there is anything to add/change.

Thanks @amedumer, for letting me know about this issue.

@0fatih 0fatih requested a review from ilgooz as a code owner August 5, 2023 10:19
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!!

nice contribution, thanks @0fatih

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (82a34f2) to head (270b8ff).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files          35       35           
  Lines        1125     1125           
=======================================
  Hits          897      897           
  Misses        197      197           
  Partials       31       31           

@Pantani
Copy link
Collaborator

Pantani commented Aug 30, 2024

closing because we are using app wiring for the modules now. @0fatih thanks for the contribution

@Pantani Pantani closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a guide about importing module
2 participants