Refactoring Default textarea size #73
Conversation
|
I see it has failed, let's see if I can fix that. |
|
Sorry if I did anything wrong, it's been awhile since I've contributed to open source and I've only done a few PRs, any help to get it approved would be appreciated. |
|
Hey @WulfPlasma, no problem at all. I am wondering what kind of setup are you running? Like which Editor or IDE and how do you make commits? It seems like something broke the |
|
I currently use atom for any Github related work |
| @@ -119,7 +124,8 @@ export interface Props extends HTMLAttributes<HTMLDivElement> { | |||
| maxContentLength?: number; | |||
| } | |||
|
|
|||
| export const InOutTextarea: FC<Props> = props => { | |||
| export const InOutTextarea: FC<Props> = (props) => { | |||
| return | |||
There was a problem hiding this comment.
This line should be removed I believe
| @@ -266,7 +271,7 @@ export const InOutTextarea: FC<Props> = props => { | |||
| <IconX size={32} /> | |||
| </IconContainer> | |||
| </TextAreaContent> | |||
| <TextAreaContent> | |||
| @@ -283,5 +288,7 @@ export const InOutTextarea: FC<Props> = props => { | |||
| </TextAreaContent> | |||
| </ConvertCardContent> | |||
| </ConvertCard> | |||
| </TextAreaContent> | |||
| </> | |||
There was a problem hiding this comment.
These two lines have to be deleted
|
Ahh alright, @WulfPlasma I made some comments on the code. Maybe you can change them. You might want to add the addon: https://atom.io/packages/language-typescript-react to your editor because this enabled proper support for this setup I believe. Before you make a commit run the command |
|
@igeligel after running |
|
Nope, it should not. It seems like something with the prettier config might be not right. I will have a detailed look tomorrow. |
|
Meanwhile I'll try to find a fix, if I'm able to fix it and not get any errors I'll make a commit. Thank you for the help. |
|
@igeligel any updates? |
|
I’ll keep the branch just incase we find a fix, for now I’ll close the PR and come back to it later if need be. |
@igeligel Let me know if I need to change anything or do anything to improve the code. Thank you for letting me work on this.