i18n: add Korean (ko) translation#578
Open
moduvoice wants to merge 2 commits into
Open
Conversation
Adds a complete Korean locale (web/src/i18n/locales/ko.json) mirroring
the full key structure of en.json (1340 leaf keys, 0 missing/extra),
with interpolation placeholders and inline tags verified to match
exactly. Registers ko in the i18next resource map (i18n/config.ts)
and the language switcher dropdown (LanguageSwitcher).
Verified with:
- python key-set diff (en vs ko): 0 missing, 0 extra
- python placeholder/tag diff ({{var}}, <1>...</1>): 0 mismatches
- pnpm vitest run (full suite): 180 files / 609 tests passed
- tsc --noEmit: no errors
- eslint on changed files: no issues
search.sort.stars was translated as "평점" (rating) instead of a star-count term, conflating it with the separate rating concept used elsewhere (e.g. skillDetail.rating). Changed to "즐겨찾기순" for consistency with the "즐겨찾기" (starred) terminology used across the other 60+ star-related keys in this file.
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
web/src/i18n/locales/ko.jsonwith a full Korean translation (1340 keys, 1:1 parity withen.json)koinweb/src/i18n/config.tsi18next resources한국어) to the language switcher inweb/src/shared/components/language-switcher.tsxTesting
en.jsonandko.jsonboth have exactly 1340 keys, 0 missing/extra{{variable}}placeholders and<1>...</1>style tags match betweenen.jsonandko.jsonpnpm vitest run— 180 files / 609 tests passingpnpm typecheck(tsc --noEmit) — cleanpnpm lint(eslint) — clean