Merged
Conversation
Implements 6 high-priority improvements from code review: Backend: - Make label business limits configurable via application.yml (max-definitions, max-per-skill) Frontend: - Split use-skill-queries.ts into domain-specific modules (label/namespace/user/skill) - Enable @typescript/no-explicit-any as warning and clean up 10 any types - Unify API error handling by removing unwrap() in favor of fetchJson() Testing: - Add label system scenarios to smoke test script - Add 6 new tests for label management UI (validation, rendering) All tests passing: 301 backend, 129 frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements 6 improvements based on code review findings from 2026-03-22:
Test plan