Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate roles from actions #312

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

SteveLasker
Copy link
Collaborator

@SteveLasker SteveLasker commented Nov 12, 2024

From the editors call on 11/12/24

  • With the addition of the relying party roles, make the top consistent
  • Change the hanging text for sign/verify to actions
  • Move Issuer as the entity that performs the actions
  • Cleanup overly detailed row for COSE_SIGN1
  • Narrow the diagram to avoid make warnings

image

Signed-off-by: steve lasker <[email protected]>
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general the concept LGTM! For future: Just a word of caution: We should make every effort to make the Architecture, look simple. Too many boxes, complicate the diagram.

@yogeshbdeshpande
Copy link
Collaborator

in general the concept LGTM! For future: Just a word of caution: We should make every effort to make the Architecture, look simple. Too many boxes, complicate the diagram.

Also, any reason why you removed cose_sign1 It was super helpful to understand that the Signed Statement was cose_sign1

@OR13
Copy link
Collaborator

OR13 commented Nov 12, 2024

@yogeshbdeshpande the reason was to keep the diagram high level, and leave details to spec text

@henkbirkholz
Copy link
Member

Also, any reason why you removed cose_sign1 It was super helpful to understand that the Signed Statement was cose_sign1

As expected, but I would like to amplify Yogesh's question.

@SteveLasker
Copy link
Collaborator Author

As expected, but I would like to amplify Yogesh's question.

We did discuss this on the call, and @OR13 's comment sums up our conversation:

@henkbirkholz, are you blocking, or are you ok if we merge the current simplified version?

@henkbirkholz
Copy link
Member

I am okay with the new version. We might apply of different meaning to the term "simplified" ☺️

@SteveLasker SteveLasker merged commit 3ca4067 into main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants