Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arch diagram to match terminology #311

Merged

Conversation

thibmeu
Copy link
Contributor

@thibmeu thibmeu commented Nov 3, 2024

Update Figure 1 to include components from the Terminology.

  • Credentials is owned by an Issuer
  • Collection of receipt is done by a Relying Party
  • Make of Transparency Statement is done by an Auditor, which is a special Relying Party

The newly generated diagram looks as follow
architecture difference

Per 4.2, Issuers are producing signed statement (with their crecdentials). Credentials is not mentioned in the Terminology section, not Credentials
Identify the relying party on the architecture diagram
These relying party can perform different actions
A specialised relying party is the auditor.
Add it to the architecture diagram
@thibmeu thibmeu changed the title Update arch digram to match terminology Update arch diagram to match terminology Nov 3, 2024
@thibmeu thibmeu force-pushed the update-arch-digram-to-match-terminology branch from ff6c724 to 1aef2c1 Compare November 3, 2024 14:11
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thibmeu
LGTM

Minor tweaks to fix the aasvg corners:
image

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yogeshbdeshpande
Copy link
Collaborator

yogeshbdeshpande commented Nov 4, 2024

@thibmeu I have a slight concern with the diagram. Normally Replay log is explicitly done by Auditor so Under Replay Log, if the role is Auditor that is a more correct representation than a Generic Relying Party what you have currently!

Also, Log Replay is a resource consuming operation and should be careful in promoting that to a generic relying parties.

I suggest renaming that aspect to Auditor

@yogeshbdeshpande
Copy link
Collaborator

Also I have a concern, Verify Transparent Statements is a job of any Relying Party, not specifically for the Auditor?

Did you intend to attach, the Auditor role to Verify Transparent Statements?

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly answer these questions please before I can approve, happy to discuss face to face!

@thibmeu
Copy link
Contributor Author

thibmeu commented Nov 4, 2024

Also I have a concern, Verify Transparent Statements is a job of any Relying Party, not specifically for the Auditor?

From the terminology

Auditor: checks the correctness and consistency of all Transparent Statements issued by a Transparency Service
Relying Party: consumes Transparent Statements, verifying their proofs and inspecting the Statement payload

I read this as the Auditor builds verified transparent statement, while the replay log is a specialised relying Party but not necessarily an auditor

Removing Auditor is also a possibility to not put too many entities, since it's relying parties anyway. What do you think?

@thibmeu
Copy link
Contributor Author

thibmeu commented Nov 4, 2024

@yogeshbdeshpande I've addressed your comments following a discusion we had in person
here is the updated diagram

Screenshot from 2024-11-04 11-41-47

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this important change!
Looks Good to Me

@SteveLasker SteveLasker merged commit c6a19ca into ietf-wg-scitt:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants