-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arch diagram to match terminology #311
Update arch diagram to match terminology #311
Conversation
Per 4.2, Issuers are producing signed statement (with their crecdentials). Credentials is not mentioned in the Terminology section, not Credentials
Identify the relying party on the architecture diagram These relying party can perform different actions
A specialised relying party is the auditor. Add it to the architecture diagram
Forgot to push the previous change
ff6c724
to
1aef2c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @thibmeu
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@thibmeu I have a slight concern with the diagram. Normally Replay log is explicitly done by Auditor so Under Replay Log, if the role is Auditor that is a more correct representation than a Generic Relying Party what you have currently! Also, Log Replay is a resource consuming operation and should be careful in promoting that to a generic relying parties. I suggest renaming that aspect to Auditor |
Also I have a concern, Verify Transparent Statements is a job of any Relying Party, not specifically for the Auditor? Did you intend to attach, the Auditor role to Verify Transparent Statements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly answer these questions please before I can approve, happy to discuss face to face!
From the terminology
I read this as the Auditor builds verified transparent statement, while the replay log is a specialised relying Party but not necessarily an auditor Removing Auditor is also a possibility to not put too many entities, since it's relying parties anyway. What do you think? |
@yogeshbdeshpande I've addressed your comments following a discusion we had in person |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this important change!
Looks Good to Me
Update Figure 1 to include components from the Terminology.
The newly generated diagram looks as follow