Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Considerations: Editorial Improvements #286

Merged
merged 17 commits into from
Sep 3, 2024
Merged

Privacy Considerations: Editorial Improvements #286

merged 17 commits into from
Sep 3, 2024

Conversation

hannestschofenig
Copy link
Collaborator

No description provided.

roywill
roywill requested changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@roywill roywill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@roywill @SteveLasker
Update draft-ietf-scitt-architecture.md
c894a89 
This does not make the comment any less useful, I would rather keep this.

Co-authored-by: Steve Lasker <[email protected]>
OR13
OR13 requested changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not assert properties of verifiable data structures beyond append only and inclusion proofs

henkbirkholz
henkbirkholz requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orie's suggestion makes sense

@henkbirkholz @OR13
Update draft-ietf-scitt-architecture.md
b52d00e 
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Orie Steele <[email protected]>
henkbirkholz and others added 3 commits July 22, 2024 01:25
@henkbirkholz @OR13
Update draft-ietf-scitt-architecture.md
c80a684 
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Orie Steele <[email protected]>
@henkbirkholz @OR13
Update draft-ietf-scitt-architecture.md
bb21f94 
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Orie Steele <[email protected]>
@henkbirkholz @OR13
Update draft-ietf-scitt-architecture.md
bae990b 
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Orie Steele <[email protected]>
@henkbirkholz @OR13
Update draft-ietf-scitt-architecture.md
09cd9f3 
Co-authored-by: Orie Steele <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Orie Steele <[email protected]>
SteveLasker
SteveLasker requested changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to leave this section and close.

draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
@henkbirkholz @hannestschofenig
Update draft-ietf-scitt-architecture.md
d6225e3 
Co-authored-by: Henk Birkholz <[email protected]>
Co-authored-by: Hannes Tschofenig <[email protected]>
@henkbirkholz @hannestschofenig
Update draft-ietf-scitt-architecture.md
aaa8a84 
Co-authored-by: Henk Birkholz <[email protected]>
Co-authored-by: Hannes Tschofenig <[email protected]>
OR13
OR13 requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge #294 first, and then address conflicts and see if anything remains

aj-stein-nist
aj-stein-nist approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this change as constructive, I asked Steve for clarification on his comments too.

@henkbirkholz @hannestschofenig
Update draft-ietf-scitt-architecture.md
e1ea7b9 
this is okay, but maybe other parts in the pr will keep it from being merged

Co-authored-by: Hannes Tschofenig <[email protected]>
yogeshbdeshpande
yogeshbdeshpande reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we incorporate Option 1 suggestion from Steve!

@SteveLasker
Copy link
Collaborator

@OR13, @henkbirkholz, PTAL at the latest if they resolve your requested changes.

SteveLasker
SteveLasker approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as of cdd13a4 improve the previous text.
LGTM

OR13
OR13 reviewed Aug 13, 2024
View reviewed changes
draft-ietf-scitt-architecture.md
Transparency Services MAY support anonymous access.
Issuers SHOULD ensure Signed Statements submitted to public access services are acceptable for public disclosure.
In this case, Signed Statements MUST NOT carry confidential information.
Once a Signed Statement is inserted into the Append-only Log maintained by a Transparency Service, it cannot be removed from the Log.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a strange way to say that Log integrity is tamper protected.

henkbirkholz
henkbirkholz reviewed Sep 3, 2024
View reviewed changes
draft-ietf-scitt-architecture.md
Transparency Services MAY support anonymous access.
Issuers SHOULD ensure Signed Statements submitted to public access services are acceptable for public disclosure.
Publicly accessible Signed Statements MUST NOT carry confidential information.
Once a Signed Statement is inserted into the Append-only Log maintained by a Transparency Service, it cannot be removed from the Log.
Copy link
Member

@henkbirkholz henkbirkholz Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once a Signed Statement is inserted into the Append-only Log maintained by a Transparency Service, it cannot be removed from the Log.
Once a Signed Statement is registered it cannot be removed from the Log.

Optional brevity

@SteveLasker SteveLasker merged commit c7982b6 into main Sep 3, 2024
2 checks passed
@SteveLasker SteveLasker deleted the hannestschofenig-patch-19 branch October 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande left review comments

@JAG-UK JAG-UK JAG-UK left review comments

@henkbirkholz henkbirkholz henkbirkholz approved these changes

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

@roywill roywill roywill approved these changes

@OR13 OR13 OR13 approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@ad-l ad-l Awaiting requested review from ad-l ad-l is a code owner

@fournet fournet Awaiting requested review from fournet fournet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hannestschofenig @SteveLasker @OR13 @henkbirkholz @JAG-UK @yogeshbdeshpande @roywill @aj-stein-nist