Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for SCRAPI #139

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Prepare for SCRAPI #139

merged 11 commits into from
Dec 12, 2023

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented Dec 5, 2023

This PR removes implementation details from the architecture, many of which are specific to SCRAPI.

@OR13 OR13 marked this pull request as ready for review December 5, 2023 16:55
@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Dec 5, 2023

Re the SCRAPI I-D reference, it does not appear to be in the IETF Datatracker system at all and noticed when it wasn't listed or clicked on a link to search by I-D name and it returned no results, @OR13. That is why I asked about this on the mailing list.

https://datatracker.ietf.org/doc/search?name=draft-birkholz-scitt-scrapi&rfcs=on&activedrafts=on&olddrafts=on

https://mailarchive.ietf.org/arch/msg/scitt/AqHH6OUrc2Xzj81JI-fD4IUB91U/

Don't we need to take care of that issue for the short-hand references to work at all? Can it not be added to the tracker in advance of being adopted by the WG? (It seems some are added and "owned" by authors and not associated with the target WG in advance in some or not all cases. Sorry, I am new here.

UPDATE: I had encountered this problem before and I guess I misread this output from the previous run. It seems whitespace is an issue but not dangling links. Disregard!

 /github/workspace/.refcache/reference.I-D.draft-birkholz-scitt-scrapi.xml: fetching from https://datatracker.ietf.org/doc/bibxml3/draft-birkholz-scitt-scrapi.xml
*** Can't get with persistent HTTP: Status code 404 while fetching https://datatracker.ietf.org/doc/bibxml3/draft-birkholz-scitt-scrapi.xml
*** 404 Not Found while fetching https://datatracker.ietf.org/doc/bibxml3/draft-birkholz-scitt-scrapi.xml
*** No such file or directory @ rb_sysopen - /github/workspace/.refcache/reference.I-D.draft-birkholz-scitt-scrapi.xml for /github/workspace/.refcache/reference.I-D.draft-birkholz-scitt-scrapi.xml

@OR13
Copy link
Collaborator Author

OR13 commented Dec 5, 2023

@aj-stein-nist hmm, you are right... seems scrapi is not published well enough to be referenced... I will have to fix that, but apparently its not blocking the PR... which is weird.

@aj-stein-nist
Copy link
Collaborator

apparently its not blocking the PR... which is weird.

I too thought it was weird, I'll look into the i-d template action and consider if there is a bug to report or enhancement to file.

@OR13
Copy link
Collaborator Author

OR13 commented Dec 5, 2023

PR against SCRAPI which can take some of these changes, but which I am intentionally leaving light.

ietf-scitt/draft-birkholz-scitt-scrapi#7

@SteveLasker
Copy link
Collaborator

fixes #117

Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be LGTM with merger of #141

@SteveLasker SteveLasker self-requested a review December 12, 2023 16:13
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Per the editors call, there was a few open questions that @fournet was going to open new issues and prs for tracking.
This PR completes the previous decision to segment the APIs into: https://github.com/ietf-scitt/draft-birkholz-scitt-scrapi/

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clarity is good.

@SteveLasker SteveLasker merged commit 0580ad7 into main Dec 12, 2023
2 checks passed
@SteveLasker SteveLasker deleted the scrapi-adoption-prep branch December 12, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants