Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Feed to Subject #114
Rename Feed to Subject #114
Changes from 1 commit
52d8851
66f536e
0bc3dc0
a8fed6b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the subject (old feed) is mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't make that explicit change, but yes an issuer of a signed statement must have a subject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 2 'crit`? Shouldn't 'sub' be nested in a 13 (see https://www.ietf.org/archive/id/draft-ietf-cose-cwt-claims-in-headers-06.html#name-representation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, yes, I incorrectly pulled
2
from the CWT spec.In this PR, we're not pulling in CWT. That is deferred to #108
This PR renames
Feed
toSubject
, aligning with the definition of Subject, within CWT.Can we agree with this incremental step? If so, what tag should we use? I can repurpose 392, but I think we agree cbor-tags should have a common tag for
subject
, which is outside the scope of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To unblock, I've set the label to 392 (previous temporary label), as a
bytestring
, similar to #111. This unblocks the rename, with the ability to relax tostring
if we decide, or possibly shift to a CWT (#108).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above reference is outdated. Please see updated line 658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #108 merged, removing this entry.