Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to rephrase the Reg_Info definition #113

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Proposal to rephrase the Reg_Info definition #113

merged 7 commits into from
Oct 18, 2023

Conversation

henkbirkholz
Copy link
Member

Fixes #112

@henkbirkholz henkbirkholz mentioned this pull request Oct 17, 2023
Merged
@SteveLasker
Copy link
Collaborator

Good clarification, with a few nits to reduce and clarify the text

JAG-UK
JAG-UK requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, a couple of small suggestions

draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
draft-ietf-scitt-architecture.md Outdated Show resolved Hide resolved
@SteveLasker SteveLasker added this to the IETF 118 milestone Oct 18, 2023
henkbirkholz and others added 2 commits October 18, 2023 16:15
@henkbirkholz @SteveLasker
Update draft-ietf-scitt-architecture.md
32181ed 
Co-authored-by: Steve Lasker <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Steve Lasker <[email protected]>
@henkbirkholz @JAG-UK
Update draft-ietf-scitt-architecture.md
b24df6a 
Co-authored-by: Jon Geater <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>

Co-authored-by: Jon Geater <[email protected]>
@SteveLasker
Copy link
Collaborator

All edits have been addressed. I believe this is ready for merging.

JAG-UK
JAG-UK approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteveLasker
SteveLasker approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it addresses all feedback and clarifies the conversations

fournet
fournet approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@fournet fournet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer "The key/value pair semantics are application-specific, or even possibly specified by each Issuer for each of their Feed." but I am fine with both formulations. Thanks.

@SteveLasker @OR13
Update draft-ietf-scitt-architecture.md
3694890 
Merging as this is a well discussed pattern with SCITT

Co-authored-by: Orie Steele <[email protected]>
@SteveLasker
Copy link
Collaborator

I would prefer "The key/value pair semantics are application-specific, or even possibly specified by each Issuer for each of their Feed." but I am fine with both formulations. Thanks.

Thanks, @fournet
Sounds like we can address this suggestion separately and we can merge this as-is

@SteveLasker SteveLasker merged commit c02c193 into main Oct 18, 2023
2 checks passed
@SteveLasker SteveLasker deleted the reg-info-patch1 branch October 23, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

@SteveLasker SteveLasker SteveLasker approved these changes

@JAG-UK JAG-UK JAG-UK approved these changes

@OR13 OR13 OR13 approved these changes

@fournet fournet fournet approved these changes

@ad-l ad-l Awaiting requested review from ad-l ad-l is a code owner

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande yogeshbdeshpande is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
IETF 118
Development

Successfully merging this pull request may close these issues.

Registration Info might need some rewording
6 participants
@henkbirkholz @SteveLasker @fournet @OR13 @JAG-UK @aj-stein-nist