Refactor ThermalEnergyDemand #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
added
enhancement
danielfeismann
commented
Nov 28, 2024
There was a problem hiding this comment.
Thanks for pushing this further, @marvinheintze! Also a good idea to add the cases for negative demands. I thought a bit on this and I guess it will be easier to go just with positive demands as we at the moment doesn't have any specific use case that requires negative demands. So please remove them again, I'm sorry for the confusion that may arised.
staudtMarius
requested review from
staudtMarius and
marvinheintze
and removed request for
marvinheintze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #917
I started here, but more needs to be done. Feel free to take over :)