Differentiate between different power types #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/scala/edu/ie3/simona/model/participant/SystemParticipant.scala
Outdated
Show resolved
Hide resolved
danielfeismann
requested changes
Jul 8, 2024
src/test/groovy/edu/ie3/simona/model/participant/FixedFeedModelTest.groovy
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/model/participant/load/random/RandomLoadModel.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/model/participant/control/QControl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/util/scala/quantities/ApparentPower.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/pv/PvAgent.scala
Outdated
Show resolved
Hide resolved
…erent-power-types # Conflicts: # src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala # src/main/scala/edu/ie3/simona/agent/participant/fixedfeedin/FixedFeedInAgentFundamentals.scala # src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala # src/main/scala/edu/ie3/simona/agent/participant/load/LoadAgentFundamentals.scala # src/main/scala/edu/ie3/simona/agent/participant/pv/PvAgentFundamentals.scala # src/main/scala/edu/ie3/simona/agent/participant/wec/WecAgentFundamentals.scala # src/test/groovy/edu/ie3/simona/model/participant/FixedFeedModelTest.groovy
|
Just as a reminder since I just checked the old issues. Could / should we handle #136 here as well? |
I think we could just add this in this PR. What's your opinion? |
|
I agree, but before you do so, please wait for the feedback of Johannes and Sebastian in the issue above. |
…erent-power-types # Conflicts: # src/test/groovy/edu/ie3/simona/model/participant/load/FixedLoadModelTest.groovy
danielfeismann
added a commit
that referenced
this pull request
Aug 1, 2024
…edInModelSpec-tests Merging both `FixedFeedInModelSpec` tests.
…erent-power-types # Conflicts: # src/main/scala/edu/ie3/simona/ontology/messages/services/PrimaryDataMessage.scala # src/test/groovy/edu/ie3/simona/model/thermal/ThermalHouseTest.groovy # src/test/scala/edu/ie3/simona/model/participant/FixedFeedModelSpec.scala
…erent-power-types # Conflicts: # src/test/groovy/edu/ie3/simona/model/participant/BMModelTest.groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #794