Fix scheduling at evcs with more than one ev at a time without em #788

danielfeismann · 2024-04-17T19:52:10Z

resolves #787

… result entries

…entries for evcs

src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala

…results for it

…at EvcsAgent

# Conflicts: # CHANGELOG.md

src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala

# Conflicts: # CHANGELOG.md

…he currentTick

# Conflicts: # CHANGELOG.md

Signed-off-by: Sebastian Peter <[email protected]>

sebastian-peter

Hitting the home stretch...

src/main/scala/edu/ie3/simona/model/participant/evcs/EvcsModel.scala

src/test/scala/edu/ie3/simona/agent/participant/EvcsAgentModelCalculationSpec.scala

src/main/scala/edu/ie3/simona/model/participant/evcs/EvcsModel.scala

src/test/scala/edu/ie3/simona/agent/participant/EvcsAgentModelCalculationSpec.scala

sebastian-peter

LGTM, thanks for you patience!

danielfeismann added 3 commits April 17, 2024 21:32

fix exception message

3a8e465

determine evcs results also in case of arriving evs to ensure correct…

0bbf22c

… result entries

add additionalActivationTick for the end of simulation to get result …

57a3e1c

…entries for evcs

danielfeismann self-assigned this Apr 17, 2024

danielfeismann added the bug Something isn't working label Apr 17, 2024

danielfeismann added this to the Version 4.0 milestone Apr 17, 2024

danielfeismann commented Apr 17, 2024

View reviewed changes

src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala Outdated Show resolved Hide resolved

danielfeismann added 23 commits April 17, 2024 21:57

changelog

dfabd10

add test case for charging three evs at same time and deliver proper …

4e01391

…results for it

remove unnecessary change

8da73ea

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

098360d

fix results for evs

0c66b02

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

497abc0

fmt

bf4b203

groupby

277ed75

newActiveEntries at EvcsModel

512842f

update stayingSchedules at EvcsAgentFundamentals

21ae63a

update stayingSchedules at EvcsAgentFundamentals

ca9ac46

add tickStart to filter condition

0e2a3b3

fix test condition

f8af4e2

remove unused method

569c38b

revert change

4188363

reintroduce explaining comment

bbf873f

rollback startingSchedules

4b5db38

reintroduce new determination of schedules

538ea67

test for provide correct results for three evs charging at same time …

64483d1

…at EvcsAgent

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

e209998

# Conflicts: # CHANGELOG.md

fix naming to comply with codacy

c97d329

fmt

09cb952

revert test case result

dc866db

sebastian-peter reviewed Aug 28, 2024

View reviewed changes

src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala Outdated Show resolved Hide resolved

danielfeismann added 10 commits September 17, 2024 15:54

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

48b45d5

# Conflicts: # CHANGELOG.md

remove unnecessary EvcsModel in EvcsInputTestData

e7814ec

rollback changes of entriesByStartTick at EvcsModel

44ae493

fmt

38515a1

fmt

4a203c9

rollback unnecessary change of filtering schedules for tick

adf3131

fmt

6919fa8

entriesByStartTick as sortedMap

902ff35

only handle results at handleArrivingEvs when there is no state for t…

ef0287d

…he currentTick

rearrange EvcsAgentModelCalculationSpec results

9119e58

danielfeismann requested a review from sebastian-peter September 18, 2024 15:30

danielfeismann and others added 6 commits September 20, 2024 08:26

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

04382dd

# Conflicts: # CHANGELOG.md

Suggestion for result matching

d87c491

Signed-off-by: Sebastian Peter <[email protected]>

refactor EvcsResult testing

f2a37fa

refactor EvResult testing

5b3665e

Merge branch 'refs/heads/dev' into df/#787_fix_evcs_scheduling

50f9d9f

Undo line deletion

1067727

Signed-off-by: Sebastian Peter <[email protected]>

sebastian-peter requested changes Sep 24, 2024

View reviewed changes

danielfeismann and others added 6 commits September 24, 2024 16:53

rollback filter of results of evcs model

3dbaf84

make EvcsModel.chargeEv private again

aa018a4

update exception message

4ec97fd

Merge branch 'dev' into df/#787_fix_evcs_scheduling

6b4dc6c

fmt

46b0ea6

remove blank cases when testing for expected messages of resultListener

e9611c1

danielfeismann requested a review from sebastian-peter September 26, 2024 05:49

Merge branch 'dev' into df/#787_fix_evcs_scheduling

c5cd7f7

sebastian-peter approved these changes Sep 26, 2024

View reviewed changes

sebastian-peter merged commit a8be401 into dev Sep 26, 2024
3 checks passed

sebastian-peter deleted the df/#787_fix_evcs_scheduling branch September 26, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scheduling at evcs with more than one ev at a time without em #788

Fix scheduling at evcs with more than one ev at a time without em #788

danielfeismann commented Apr 17, 2024

sebastian-peter left a comment

sebastian-peter left a comment

Fix scheduling at evcs with more than one ev at a time without em #788

Fix scheduling at evcs with more than one ev at a time without em #788

Conversation

danielfeismann commented Apr 17, 2024

sebastian-peter left a comment

Choose a reason for hiding this comment

sebastian-peter left a comment

Choose a reason for hiding this comment