Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External simulation: Providing information about next tick of MobSim #777

Merged
merged 25 commits into from
Aug 15, 2024
Merged

External simulation: Providing information about next tick of MobSim #777

merged 25 commits into from
Aug 15, 2024

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter added the enhancement New feature or request label Mar 22, 2024
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Mar 22, 2024
@sebastian-peter sebastian-peter self-assigned this Mar 22, 2024
@sebastian-peter sebastian-peter changed the title Providing detailed information about next tick per agent External simulation: Providing detailed information about next tick per agent Mar 22, 2024
@sebastian-peter
Merge branch 'dev' into sp/#776-ext-sim-next-tick
a49c0ff
@sebastian-peter
More implementation & cleanup
19bed20
@sebastian-peter
Adapting to changes in simonaAPI interface
2ac0ceb 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Merge branch 'refs/heads/dev' into sp/#776-ext-sim-next-tick
cf8237f 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgent.scala
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgentFundamentals.scala
#	src/test/scala/edu/ie3/simona/agent/participant/EvcsAgentModelCalculationSpec.scala
@sebastian-peter sebastian-peter changed the title External simulation: Providing detailed information about next tick per agent External simulation: Providing information about next tick of MobSim Jun 21, 2024
jo-bao
jo-bao reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always good work! Maybe you can also update ExtEvSimulationSequence.puml?

src/main/scala/edu/ie3/simona/service/ev/ExtEvDataService.scala Show resolved Hide resolved
src/main/scala/edu/ie3/simona/service/ev/ExtEvDataService.scala Show resolved Hide resolved
@sebastian-peter
Merge branch 'refs/heads/dev' into sp/#776-ext-sim-next-tick
5d32101 
# Conflicts:
#	CHANGELOG.md
#	src/test/scala/edu/ie3/simona/service/ev/ExtEvDataServiceSpec.scala
@sebastian-peter
Adapt to changed ev protocol
2d32cf3 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Handling requests also in case activation has already arrived
a5753d5 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Merge branch 'refs/heads/dev' into sp/#776-ext-sim-next-tick
cfde81d 
# Conflicts:
#	CHANGELOG.md
@sebastian-peter
Explanatory commentary
1da5700 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Updating simonaAPI to release version 0.5
2b40f2e 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Refactoring old EvMovement classes
1f0a885 
Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter
Copy link
Member Author

ExtEvSimulationClasses will be dealt with in #898, ExtEvSimulationSequence I'm taking care of myself.

@sebastian-peter
Updating UML documentation related to mobility simulation (class diag…
22450d0 
…ram needs some more work)

Signed-off-by: Sebastian Peter <[email protected]>
@sebastian-peter sebastian-peter marked this pull request as ready for review August 12, 2024 14:37
@sebastian-peter sebastian-peter mentioned this pull request Aug 12, 2024
Closed
danielfeismann
danielfeismann previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe @jo-bao would like to also a view here?

jo-bao
jo-bao previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

danielfeismann
danielfeismann approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-peter sebastian-peter merged commit 53ef1af into dev Aug 15, 2024
4 checks passed
@sebastian-peter sebastian-peter deleted the sp/#776-ext-sim-next-tick branch August 15, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

@jo-bao jo-bao jo-bao left review comments

Assignees

@sebastian-peter sebastian-peter

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

EV simulations should provide next tick to ExtEvDataService as well
3 participants
@sebastian-peter @danielfeismann @jo-bao