Skip to content

Fix three winding transformer calculation #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 13, 2023
Merged

Fix three winding transformer calculation #64

merged 21 commits into from
Apr 13, 2023

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 10, 2022

Resolves #63

@ckittl ckittl added the bug Something isn't working label Jan 10, 2022
@ckittl ckittl requested a review from a team January 10, 2022 16:52
@ckittl ckittl self-assigned this Jan 10, 2022
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #64 (f553d22) into dev (f4adceb) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #64      +/-   ##
==========================================
- Coverage   80.22%   80.18%   -0.05%     
==========================================
  Files         161      161              
  Lines        5917     5910       -7     
  Branches       81       82       +1     
==========================================
- Hits         4747     4739       -8     
- Misses       1170     1171       +1
Impacted Files Coverage Δ
...edu/ie3/simona/model/grid/Transformer3wModel.scala 89.81% <0.00%> (-3.11%) ⬇️
...edu/ie3/simona/agent/grid/GridResultsSupport.scala 75.93% <0.00%> (+1.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

danielfeismann
danielfeismann reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe there should be two real reviews rather then one and me :)

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@ckittl ckittl requested a review from danielfeismann March 14, 2022 13:43
danielfeismann
danielfeismann previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you :)

@ckittl
Merge remote-tracking branch 'origin/dev' into ck/#63-threeWindingFix
afa1e3e 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/model/grid/Transformer3wModel.scala
#	src/test/scala/edu/ie3/simona/test/common/input/Transformer3wTestData.scala
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
danielfeismann
danielfeismann reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor thing

@t-ober t-ober self-assigned this Apr 25, 2022
t-ober
t-ober requested changes Apr 25, 2022
View reviewed changes
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
1 similar comment
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage84.21% Coverage (81.70% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

Daniel Feismann and others added 3 commits July 31, 2022 12:43
Merge branch 'dev' into ck/#63-threeWindingFix
c35bea0 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/agent/grid/GridResultsSupport.scala
@danielfeismann
change to correct units
6c3acf3
@danielfeismann
adapting phase-to-ground admittance at TWT calculation
f9355de
@danielfeismann danielfeismann requested a review from t-ober July 31, 2022 13:04
@t-ober t-ober merged commit 093e3ed into dev Apr 13, 2023
@t-ober t-ober deleted the ck/#63-threeWindingFix branch April 13, 2023 09:45
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann left review comments

@t-ober t-ober t-ober approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@ckittl ckittl

@t-ober t-ober

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Correct calculation logic of three winding transformer
4 participants
@ckittl @t-ober @danielfeismann @sebastian-peter