Skip to content

fixing RefSystemTest #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2023
Merged

fixing RefSystemTest #561

merged 3 commits into from
Jul 4, 2023

Conversation

danielfeismann
Copy link
Member

resolves #560

@danielfeismann danielfeismann added the test Issues related to (unit) tests label Jul 3, 2023
@julianhohmann julianhohmann self-requested a review July 3, 2023 12:49
@danielfeismann danielfeismann marked this pull request as ready for review July 3, 2023 12:50
@danielfeismann danielfeismann self-assigned this Jul 3, 2023
@danielfeismann danielfeismann mentioned this pull request Jul 3, 2023
Merged
sebastian-peter
sebastian-peter previously requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreal that we had these broken tests in here without noticing... Thanks for fixing this!

I have only a small wish for another small fix in there.

@danielfeismann danielfeismann dismissed sebastian-peter’s stale review July 4, 2023 09:41

Change request included

@danielfeismann danielfeismann merged commit ff1c410 into dev Jul 4, 2023
@danielfeismann danielfeismann deleted the df/#560-fix-refsystemTest branch July 4, 2023 09:42
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter left review comments

+1 more reviewer

@julianhohmann julianhohmann julianhohmann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@danielfeismann danielfeismann

Labels
test Issues related to (unit) tests
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Fix RefSystemTest
3 participants
@danielfeismann @sebastian-peter @julianhohmann