Skip to content

Handle codacy issues #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2023
Merged

Handle codacy issues #558

merged 6 commits into from
Jul 13, 2023

Conversation

danielfeismann
Copy link
Member

resolves #557

@danielfeismann danielfeismann self-assigned this Jun 28, 2023
@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Jun 28, 2023
@danielfeismann danielfeismann marked this pull request as ready for review June 28, 2023 12:37
sebastian-peter
sebastian-peter approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@danielfeismann danielfeismann merged commit 93cf3ee into dev Jul 13, 2023
@danielfeismann danielfeismann deleted the df/#557-codacy branch July 13, 2023 12:48
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@jo-bao jo-bao Awaiting requested review from jo-bao

@julianhohmann julianhohmann Awaiting requested review from julianhohmann

Assignees

@danielfeismann danielfeismann

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Fix some codacy issues
2 participants
@danielfeismann @sebastian-peter