Skip to content

Conversation

sebastian-peter
Copy link
Member

Resolves #19

This is a renewed PR of #26

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #30 (787c491) into dev (17e5231) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
+ Coverage   79.31%   79.32%   +0.01%     
==========================================
  Files         155      155              
  Lines        5747     5746       -1     
  Branches       80       80              
==========================================
  Hits         4558     4558              
+ Misses       1189     1188       -1     
Impacted Files Coverage Δ
...agent/participant/evcs/EvcsAgentFundamentals.scala 87.17% <0.00%> (-0.33%) ⬇️
...c/main/scala/edu/ie3/simona/agent/ValueStore.scala 91.66% <0.00%> (+0.75%) ⬆️
...a/edu/ie3/simona/service/ev/ExtEvDataService.scala 91.13% <0.00%> (+0.89%) ⬆️
.../ie3/simona/agent/participant/evcs/EvcsAgent.scala 77.77% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b9edc...787c491. Read the comment docs.

@sebastian-peter sebastian-peter self-assigned this Dec 13, 2021
@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Dec 14, 2021
@johanneshiry johanneshiry changed the base branch from dev_dep to dev December 16, 2021 09:52
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (81.60% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.50% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@ckittl ckittl merged commit a779d00 into dev Jan 11, 2022
@ckittl ckittl deleted the sp/#19-separate-lots-request branch January 11, 2022 08:08
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move parking lot request out of calculatePowerWithSecondaryDataAndGoToIdle
2 participants