Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Deployment to Maven-Central in GitHub Actions #1055

Merged
merged 33 commits into from
Dec 6, 2024

Conversation

PhilippSchmelter
Copy link
Contributor

@PhilippSchmelter PhilippSchmelter commented Nov 27, 2024

Solves #1029
This pull request includes several changes to the CI/CD pipeline, updates to the changelog, and improvements to Gradle scripts. The most important changes focus on enhancing the deployment process and improving the error messages for branch name validation.

CI/CD Pipeline Enhancements:

  • Added environment variables for Maven Central deployment and updated the deployment process to dynamically determine the version based on the branch (main or dev). (.github/workflows/ci.yml)

Changelog Updates:

  • Documented the implementation of the GitHub Actions Pipeline. (CHANGELOG.md)
  • Noted the fix for deployment of simona to Maven Central in the new GitHub Actions Pipeline. (CHANGELOG.md)

Gradle Script Improvements:

  • Enhanced the error message for invalid branch names to include the current branch name. (gradle/scripts/branchName.gradle)
  • Moved the signing configuration to use in-memory PGP keys and updated the publication signing process. (gradle/scripts/mavenCentralPublish.gradle)
  • Registered currentVersion and devVersion tasks using the tasks.register method for better task management. (gradle/scripts/semVer.gradle)

@PhilippSchmelter PhilippSchmelter added bug Something isn't working ci Related to continuous integration labels Nov 27, 2024
@PhilippSchmelter PhilippSchmelter self-assigned this Nov 27, 2024
@PhilippSchmelter PhilippSchmelter linked an issue Nov 27, 2024 that may be closed by this pull request
@PhilippSchmelter PhilippSchmelter marked this pull request as ready for review December 3, 2024 12:33
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

@sebastian-peter sebastian-peter merged commit caeaad0 into dev Dec 6, 2024
4 checks passed
@sebastian-peter sebastian-peter deleted the ps/#1029-FixDeployment branch December 6, 2024 15:34
@PhilippSchmelter
Copy link
Contributor Author

Thanks a lot for fixing this!

Thanks a lot for helping! I think this one is on both of us :D

@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair/implement OSSRH releases in GHA
2 participants