-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ThermalGridDemand #917
Labels
Comments
danielfeismann
added
enhancement
New feature or request
HiWiStart
Good for New HiWis
labels
Aug 21, 2024
danielfeismann
added a commit
that referenced
this issue
Aug 21, 2024
…ermalEnergyDemand' into df/#827_fix_hp_storage_refill
marvinheintze
added a commit
that referenced
this issue
Dec 3, 2024
marvinheintze
added a commit
that referenced
this issue
Dec 17, 2024
staudtMarius
added a commit
that referenced
this issue
Dec 18, 2024
Update:
|
danielfeismann
added a commit
that referenced
this issue
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In my opinion the ThermalGridDemand should
Definitions in ScalaDoc state
required
as the absolutely required demand andpossible
for the maximum demand. We named it additionalDemand later, which is a bit misleading. In my point of view we should use it in the meaning of min and max. Thusdef hasAdditionalDemand
should check if possible > zero not > requiredhasRequiredNegativeDemand
(maybe find a better wording) make sense?Not sure about:
I started but maybe someone would take over this
The text was updated successfully, but these errors were encountered: