Register missing units to addUnit #282

danielfeismann · 2022-07-22T06:03:58Z

resolves #280

codecov · 2022-07-22T06:06:44Z

Codecov Report

Patch coverage has no change and project coverage change: +0.24 🎉

Comparison is base (ee06fe3) 67.46% compared to head (1a8b43f) 67.71%.

❗ Current head 1a8b43f differs from pull request most recent head 09145db. Consider uploading reports for the commit 09145db to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #282      +/-   ##
============================================
+ Coverage     67.46%   67.71%   +0.24%     
  Complexity      234      234              
============================================
  Files            42       42              
  Lines          1297     1307      +10     
  Branches        124      124              
============================================
+ Hits            875      885      +10     
  Misses          388      388              
  Partials         34       34

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

# Conflicts: # src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java

…into df/#280_addUnit_quantity_units

src/test/groovy/edu/ie3/util/quantities/PowerSystemUnitsTest.groovy

# Conflicts: # CHANGELOG.md # src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java

sebastian-peter · 2023-06-26T13:26:28Z

src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java

-    // varh, kvarh, Mvarh are kept out of this because they register for the same units as Wh, kWh,
-    // MWh


I added this remark for a reason... Something broke, when I added varh etc., because they collided with Wh etc.
You should do thorough testing, also in SIMONA, with this...

src/main/java/edu/ie3/util/quantities/PowerSystemUnits.java

sonarqubegithubprchecks · 2023-07-03T17:08:28Z

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (66.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

# Conflicts: # CHANGELOG.md

danielfeismann · 2024-01-30T11:31:28Z

Does it make sense to keep on here with respect to squants? Whats your opinion @sebastian-peter

sebastian-peter · 2024-01-30T13:05:38Z

@danielfeismann I think this can still be valuable, we're not close to being completely done with javax quantities

register MWh, kvarh, Mvarh and varh to addUnit

18cabf0

danielfeismann added the enhancement New feature or request label Jul 22, 2022

danielfeismann self-assigned this Jul 22, 2022

Merge branch 'main' into df/#280_addUnit_quantity_units

c0c47de