Skip to content

Enhancing Validation for sRated of HpTypeInput #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2025
Merged

Enhancing Validation for sRated of HpTypeInput #1395

merged 6 commits into from
Jul 25, 2025

Conversation

@danielfeismann
Copy link
Member

resolves #1394

@danielfeismann danielfeismann added this to the Version 8.1 milestone Jul 25, 2025
@danielfeismann danielfeismann self-assigned this Jul 25, 2025
@danielfeismann danielfeismann added test Related to tests model Related to the data model (conceptually, not to the implementation) labels Jul 25, 2025
@danielfeismann danielfeismann marked this pull request as ready for review July 25, 2025 08:29
@danielfeismann danielfeismann marked this pull request as draft July 25, 2025 09:05
@danielfeismann danielfeismann marked this pull request as ready for review July 25, 2025 09:11
staudtMarius
staudtMarius requested changes Jul 25, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small question.

@danielfeismann danielfeismann mentioned this pull request Jul 25, 2025
Open
2 tasks
@staudtMarius staudtMarius merged commit 67da4a1 into dev Jul 25, 2025
4 checks passed
@staudtMarius staudtMarius deleted the df/#1394-hpTypeInput-validation-srated branch July 25, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels

model Related to the data model (conceptually, not to the implementation) test Related to tests

Projects

None yet

Milestone

Version 8.1

Development

Successfully merging this pull request may close these issues.

Enhance HpTypeInput Validation to check for valid sRated

3 participants

@danielfeismann @staudtMarius