Improving error message when using the outdated csv format #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested changes
Jul 1, 2024
There was a problem hiding this comment.
The existing error message (The size of the headline does not fit to the size of the resulting fields to attributes mapping.) could also be made more clear. I'd remove the print of fieldsToAttributesKeySet, since it's just going to be headline with a maximum size of the length of fieldVals.
Please also make sure that there are tests for both cases: Too many and too little headline fields.
src/main/java/edu/ie3/datamodel/io/source/csv/CsvDataSource.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1112