Skip to content

Commit

Permalink
mmlicense: do not check against "requiredLicense" field
Browse files Browse the repository at this point in the history
When a new node is added for the first time to GPFS (without specifying
a license on mmaddnode), the Host probably gets assigned the "client"
license by default.
Now if you want to designate the Host as a server afterwards, this check
would prevent you to do so, since by default the "requiredLicense" is
set to "client".
This check isn't really needed anyway, because I assume one can just
treat the "requiredLicense" field in mmlslicense as a "hint". The only
thing that matters is the designatedLicense.

Additionally, GPFS will somehow anyway rewrite this internally at some
point. Recently added a new node and designated it as "server".
mmslicense shows "client" for "requiredLicense" and "server" for
"designatedLicense" as expected. Some time later, mmlslicense showed
"server" as "requiredLicense", and "fpo-server" for "designatedLicense".
  • Loading branch information
tazend authored and wookietreiber committed May 30, 2024
1 parent b5badf4 commit c807817
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions library/mmlicense.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def main():

for row in mmls_xsv:
if row['nodeName'] == node:
current['required'] = row['requiredLicense']
current['designated'] = row['designatedLicense']
break

Expand All @@ -60,16 +59,6 @@ def main():
mmlslicense=mmls,
)

if lic != current['required']:
module.fail_json(
msg="%s target %s license does not match required %s license" % (
node,
lic,
current['required']
),
mmlslicense=mmls,
)

changed = lic != current['designated']

# -------------------------------------------------------------------------
Expand Down

0 comments on commit c807817

Please sign in to comment.