Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/10 add rates in export url #16

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Thykof
Copy link
Member

@Thykof Thykof commented Oct 4, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/idesys-dev/jeh-maker/4ugh42EtiqAViqsDQMKpucENaPY3
✅ Preview: https://jeh-maker-git-feature-10-add-rates-in-export-url-idesys-dev.vercel.app

@netlify
Copy link

netlify bot commented Oct 4, 2021

👷 Deploy Preview for jeh-marker-storybook processing.

🔨 Explore the source changes: e9d41ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/jeh-marker-storybook/deploys/61d4c3bd9cef050008c640d7

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #16 (f034c13) into master (7012212) will increase coverage by 7.14%.
The diff coverage is 75.00%.

❗ Current head f034c13 differs from pull request most recent head e9d41ac. Consider uploading reports for the commit e9d41ac to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   34.38%   41.53%   +7.14%     
==========================================
  Files          22       22              
  Lines         442      443       +1     
  Branches       34       34              
==========================================
+ Hits          152      184      +32     
+ Misses        288      257      -31     
  Partials        2        2              
Impacted Files Coverage Δ
src/components/Taux.vue 42.85% <0.00%> (+42.85%) ⬆️
src/views/Home.vue 0.00% <ø> (ø)
src/components/Phase.vue 16.41% <50.00%> (-0.25%) ⬇️
src/components/JehMaker.vue 64.22% <100.00%> (+22.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7012212...e9d41ac. Read the comment docs.

Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une p'tit remarque 😉

src/components/JehMaker.vue Outdated Show resolved Hide resolved
BilelJegham
BilelJegham previously approved these changes Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants