-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmd line arg to suppress header output #29669
Add cmd line arg to suppress header output #29669
Conversation
ca8cd71
to
1c1b30b
Compare
Job Coverage, step Generate coverage on 510f565 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
e25f75a
to
3ba6e2e
Compare
Can someone pass judgement on including a test on this @GiudGiud @loganharbour @pbehne ? The simplest is a |
I think we should just make another dummy app for it so that we don't get a header in every moose_test-opt run |
Could also put a header in |
I don't like testing framework content outside of the framework. misc testing doesn't contribute to framework coverage for example. If we don't want another app, we can just do something silly like
but we've done worse. |
Job Documentation, step Docs: sync website on 510f565 wanted to post the following: View the site here This comment will be updated on new commits. |
Nice! I like this option! |
Pretty easy to put
in |
It's not very useful imo |
3ba6e2e
to
106a83b
Compare
This works for cascading to subapps @loganharbour ...maybe that previous fix you suggested did work 😬 |
Alright, ready for review! |
Does this #29671 fix the missing prefix in the indentation reported in the issue? |
106a83b
to
87ce983
Compare
Yeah mostly, but this still adds the capability to turn off the header. This is good to go for review @loganharbour . Thanks! |
Thanks @loganharbour ! |
Combined #29663 into this. Changed the header output stream to
_console
, and added command line arg to suppress header output. Added command line arg toMooseTestApp
to optionally print a header to allow testing.Closes #29662