Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BZip2Constants static instead of sealed #625

Merged
merged 1 commit into from
May 11, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented May 8, 2021

Fixes some CA1812 analyzer warnings.

I made the change looking at the output from #449 and then noticed that #417 contains the same change, though i'm not sure what state that one is in now.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #625 (e19179f) into master (34879be) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   73.35%   73.37%   +0.02%     
==========================================
  Files          68       68              
  Lines        8721     8719       -2     
==========================================
+ Hits         6397     6398       +1     
+ Misses       2324     2321       -3     
Impacted Files Coverage Δ
...rc/ICSharpCode.SharpZipLib/BZip2/BZip2Constants.cs 0.00% <ø> (ø)
...Code.SharpZipLib/Zip/Compression/DeflaterEngine.cs 87.45% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34879be...e19179f. Read the comment docs.

@piksel piksel merged commit e839500 into icsharpcode:master May 11, 2021
@Numpsy Numpsy deleted the rw/ca1812 branch May 11, 2021 12:20
HowToDoThis added a commit to HowToDoThis/SharpZipLib that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants