Suppress some more CA1707 warnings in the Constants classes #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 70.96% 73.04% +2.07%
==========================================
Files 68 68
Lines 13417 8722 -4695
==========================================
- Hits 9522 6371 -3151
+ Misses 3895 2351 -1544
Continue to review full report at Codecov.
|
piksel
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just continuing to chip away at the warnings/suggestions from #449 by disabling some more CA1707 warnings.
Note: Some of the warnings from
ZipConstantsare actually on things that have been marked as[Obsolete], e,g,VERSION_MADE_BY- I don't know if there are any plans to remove those any point?I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.