Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress some more CA1707 warnings in the Constants classes #605

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Mar 15, 2021

Just continuing to chip away at the warnings/suggestions from #449 by disabling some more CA1707 warnings.

Note: Some of the warnings from ZipConstants are actually on things that have been marked as [Obsolete], e,g, VERSION_MADE_BY - I don't know if there are any plans to remove those any point?

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #605 (3b4925c) into master (7ed87d1) will increase coverage by 2.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   70.96%   73.04%   +2.07%     
==========================================
  Files          68       68              
  Lines       13417     8722    -4695     
==========================================
- Hits         9522     6371    -3151     
+ Misses       3895     2351    -1544     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/GZip/GZipConstants.cs 0.00% <ø> (ø)
...e.SharpZipLib/Zip/Compression/DeflaterConstants.cs 100.00% <ø> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipConstants.cs 0.00% <ø> (ø)
...pZipLib/Core/Exceptions/StreamDecodingException.cs 60.00% <0.00%> (-6.67%) ⬇️
...pLib/Core/Exceptions/StreamUnsupportedException.cs 60.00% <0.00%> (-6.67%) ⬇️
.../Core/Exceptions/UnexpectedEndOfStreamException.cs 60.00% <0.00%> (-6.67%) ⬇️
src/ICSharpCode.SharpZipLib/Checksum/Adler32.cs 81.81% <0.00%> (-3.29%) ⬇️
...pCode.SharpZipLib/Zip/Compression/PendingBuffer.cs 74.13% <0.00%> (-3.14%) ⬇️
.../ICSharpCode.SharpZipLib/Core/FileSystemScanner.cs 48.73% <0.00%> (-2.91%) ⬇️
...e.SharpZipLib/Zip/Compression/InflaterDynHeader.cs 91.48% <0.00%> (-2.17%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed87d1...3b4925c. Read the comment docs.

@piksel piksel merged commit 1493f69 into icsharpcode:master Apr 27, 2021
@Numpsy Numpsy deleted the rw/1707_again branch April 27, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants