Skip to content

Add ReferenceTrimmer and remove unused references #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfederm wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −5
Open

Add ReferenceTrimmer and remove unused references #3666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98b9342
Add ReferenceTrimmer and remove unused references
dfederm Feb 17, 2026
c11804f
Fix lock files(?)
dfederm Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project>
<PropertyGroup>
<NoWarn>$(NoWarn);NU1510</NoWarn>
<NoWarn>$(NoWarn);NU1510;CS1591</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Copy link
Member

@siegfriedpammer siegfriedpammer Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add this?

Copy link
Author

@dfederm dfederm Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It improves the accuracy of the Roslyn APIs that ReferenceTrimmer uses. The compiler doesn't report accurate results without it.

More info: https://github.com/dfederm/ReferenceTrimmer?tab=readme-ov-file#c

Copy link
Member

@siegfriedpammer siegfriedpammer Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah that's weird Roslyn behavior. I don't think that the way comments are parsed should influence that, but OK.

Can we make this whole feature opt-in? I don't think we want to have ReferenceTrimmer listed as a dependency in the SBOM or the lock files...

Also the usefulness of this feature is not clear... The only projects where it found something are our unit test projects where we don't really have to be careful about dependencies.

Copy link
Author

@dfederm dfederm Feb 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can make it either opt in or I can just remove those bits and just remove the existing unused refs and call it a day. Ill defer to you.

The benefit of leaving it enabled though to tonstay clean wrt references. But ultimately its up tonyou.

Note: it won't be listed as a dependency in nuget packages if thats what you mean. Its a dev dependency only. If you mean a dependency semantically, or of the repo as a whole, then sure.

</PropertyGroup>

<PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
</ItemGroup>
<ItemGroup>
<GlobalPackageReference Include="ReferenceTrimmer" Version="3.4.5" />
<GlobalPackageReference Include="TomsToolbox.Composition.Analyzer" Version="2.22.2" />
</ItemGroup>
</Project>
6 changes: 6 additions & 0 deletions ICSharpCode.BamlDecompiler/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
"resolved": "4.1.5",
"contentHash": "i5z+cNu/cOcdO0AgFB8aXk8w6In2H+haaDfSgd9ImvQIK+rSHavHZIogVoAZLL8jLwYx4bAcs5b7EyuMMG4mQQ=="
},
"ReferenceTrimmer": {
"type": "Direct",
"requested": "[3.4.5, )",
"resolved": "3.4.5",
"contentHash": "I3vQerUFZ3BSrPfdpAUZX+OIEj9rf/BZ0p/Dc+KlygFHsGa3zekygNhqoPOP6/p06ql1lAcGmrqJGpsLOb6Yfw=="
},
"TomsToolbox.Composition.Analyzer": {
"type": "Direct",
"requested": "[2.22.2, )",
Expand Down
1 change: 0 additions & 1 deletion ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
<PackageReference Include="Mono.Cecil" />
<PackageReference Include="Microsoft.NETCore.ILAsm" />
<PackageReference Include="Microsoft.NETCore.ILDAsm" />
<PackageReference Include="System.Resources.Extensions" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 6 additions & 0 deletions ICSharpCode.ILSpyCmd/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@
"NuGet.Packaging": "7.3.0"
}
},
"ReferenceTrimmer": {
"type": "Direct",
"requested": "[3.4.5, )",
"resolved": "3.4.5",
"contentHash": "I3vQerUFZ3BSrPfdpAUZX+OIEj9rf/BZ0p/Dc+KlygFHsGa3zekygNhqoPOP6/p06ql1lAcGmrqJGpsLOb6Yfw=="
},
"System.Security.Cryptography.Pkcs": {
"type": "Direct",
"requested": "[10.0.3, )",
Expand Down
6 changes: 6 additions & 0 deletions ICSharpCode.ILSpyX/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
"resolved": "0.11.6",
"contentHash": "f33RkDtZO8VlGXCtmQIviOtxgnUdym9xx/b1p9h91CRGOsJFxCFOFK1FDbVt1OCf1aWwYejUFa2MOQyFWTFjbA=="
},
"ReferenceTrimmer": {
"type": "Direct",
"requested": "[3.4.5, )",
"resolved": "3.4.5",
"contentHash": "I3vQerUFZ3BSrPfdpAUZX+OIEj9rf/BZ0p/Dc+KlygFHsGa3zekygNhqoPOP6/p06ql1lAcGmrqJGpsLOb6Yfw=="
},
"System.Composition.AttributedModel": {
"type": "Direct",
"requested": "[10.0.3, )",
Expand Down
3 changes: 1 addition & 2 deletions ILSpy.BamlDecompiler.Tests/ILSpy.BamlDecompiler.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\ICSharpCode.BamlDecompiler\ICSharpCode.BamlDecompiler.csproj" />
<ProjectReference Include="..\ICSharpCode.Decompiler.Tests\ICSharpCode.Decompiler.Tests.csproj" />
<ProjectReference Include="..\ILSpy.BamlDecompiler\ILSpy.BamlDecompiler.csproj" />
<ProjectReference Include="..\ILSpy\ILSpy.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion ILSpy.Tests/ILSpy.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="DiffLib" />
<PackageReference Include="NSubstitute" />
<PackageReference Include="NSubstitute.Analyzers.CSharp">
<PrivateAssets>all</PrivateAssets>
Expand Down
Loading