Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading raw metadata blobs and Portable PDBs #3149

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Support reading raw metadata blobs and Portable PDBs #3149

merged 5 commits into from
Jan 4, 2024

Conversation

siegfriedpammer
Copy link
Member

@siegfriedpammer siegfriedpammer commented Dec 31, 2023 •
edited
Loading

Closes #3068, also adds new icons for all metadata nodes.

  • Can now directly open portable PDB files and other files in ECMA-335 metadata format

Icon changes:

before

image

after

image

@siegfriedpammer
Copy link
Member Author

@jkoritzinsky you might want to test this locally and please provide feedback and suggest features/improvements... Thanks a lot!

jkoritzinsky
jkoritzinsky approved these changes Jan 4, 2024
View reviewed changes
Copy link

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The experience looks great to me! Thank you!

@siegfriedpammer siegfriedpammer marked this pull request as ready for review January 4, 2024 18:47
@siegfriedpammer siegfriedpammer merged commit 47ac132 into master Jan 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support reading raw metadata blobs and Portable PDBs
2 participants
@siegfriedpammer @jkoritzinsky