Skip to content

Rectable selection fixes #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reejk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rectable selection fixes #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a879f1
When pressing Tab in zero length rectangle selection, simply insert t…
reejk Aug 19, 2026
7da3dcf
fix zero-length rectangle selection backspace
reejk Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ICSharpCode.AvalonEdit/Editing/EditingCommandHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ static void OnTab(object target, ExecutedRoutedEventArgs args)
TextArea textArea = GetTextArea(target);
if (textArea != null && textArea.Document != null) {
using (textArea.Document.RunUpdate()) {
if (textArea.Selection.IsMultiline) {
if (textArea.Selection.IsMultiline && !textArea.Selection.IsEmpty) {
var segment = textArea.Selection.SurroundingSegment;
DocumentLine start = textArea.Document.GetLineByOffset(segment.Offset);
DocumentLine end = textArea.Document.GetLineByOffset(segment.EndOffset);
Expand Down
5 changes: 4 additions & 1 deletion ICSharpCode.AvalonEdit/Editing/RectangleSelection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,10 @@ public override void ReplaceSelectionWithText(string newText)
pos = new TextViewPosition(document.GetLocation(editOffset + firstInsertionLength));
textArea.ClearSelection();
}
textArea.Caret.Position = textArea.TextView.GetPosition(new Point(GetXPos(textArea, pos), textArea.TextView.GetVisualTopByDocumentLine(Math.Max(startLine, endLine)))).GetValueOrDefault();

DocumentLine documentLine = textArea.Document.GetLineByNumber(Math.Max(startLine, endLine));
VisualLine visualLine = textArea.TextView.GetOrConstructVisualLine(documentLine);
textArea.Caret.Position = visualLine.GetTextViewPosition(new Point(GetXPos(textArea, pos), visualLine.VisualTop), EnableVirtualSpace);
}
}

Expand Down