Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/java intent contracts #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

0ptimizerr
Copy link
Collaborator

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (c7dae72) to head (54fc14b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
- Coverage     89.62%   89.51%   -0.12%     
  Complexity       77       77              
============================================
  Files            39       39              
  Lines          2275     2307      +32     
  Branches         37       37              
============================================
+ Hits           2039     2065      +26     
- Misses          219      225       +6     
  Partials         17       17              
Flag Coverage Δ
java 85.60% <ø> (ø)
solidity 86.11% <ø> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the
https://github.com/icon-project/IIPs/blob/master/IIPS/iip-2.md
and
https://github.com/icon-project/ICON-Projects-Planning/blob/main/adr/Intents.md

This seems to be a translations from solidity. but this is not a evm chain and works differently.
Token deposits need to be via tokenFallback. Tokens have no transfer from or allowance.
So all logic pertaining to permit2 can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants