-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/java intent contracts #8
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
============================================
- Coverage 89.62% 89.51% -0.12%
Complexity 77 77
============================================
Files 39 39
Lines 2275 2307 +32
Branches 37 37
============================================
+ Hits 2039 2065 +26
- Misses 219 225 +6
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the
https://github.com/icon-project/IIPs/blob/master/IIPS/iip-2.md
and
https://github.com/icon-project/ICON-Projects-Planning/blob/main/adr/Intents.md
This seems to be a translations from solidity. but this is not a evm chain and works differently.
Token deposits need to be via tokenFallback. Tokens have no transfer from or allowance.
So all logic pertaining to permit2 can be removed.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: