Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer expection issue for wasm header #195

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Nov 23, 2023

No description provided.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #195 (7dd2224) into main (fffa1dc) will decrease coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 7dd2224 differs from pull request most recent head 26ed87b. Consider uploading reports for the commit 26ed87b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   11.56%   11.55%   -0.02%     
==========================================
  Files          83       83              
  Lines       20011    20029      +18     
==========================================
  Hits         2314     2314              
- Misses      17445    17463      +18     
  Partials      252      252              
Files Coverage Δ
relayer/chains/icon/icon_chain_processor.go 0.00% <0.00%> (ø)
relayer/chains/wasm/query.go 0.00% <0.00%> (ø)
relayer/chains/icon/utils.go 26.84% <0.00%> (+0.17%) ⬆️
relayer/processor/path_end_runtime.go 0.00% <0.00%> (ø)
relayer/processor/message_processor.go 0.00% <0.00%> (ø)
relayer/chains/wasm/tx.go 0.00% <0.00%> (ø)
relayer/chains/wasm/wasm_chain_processor.go 0.00% <0.00%> (ø)

@izyak izyak added the bug Something isn't working label Nov 23, 2023
Copy link
Collaborator

@viveksharmapoudel viveksharmapoudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@viveksharmapoudel viveksharmapoudel merged commit 7c51b1c into main Nov 24, 2023
5 checks passed
@viveksharmapoudel viveksharmapoudel deleted the feat/nil-pointer-during-update-188 branch November 24, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants