Update IISS4 APIs to icon_chainscore_api.md #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Dec 6, 2023
goldworm-icon
commented
- requestUnjail()
- getSlashingRates(), setSlashingRates()
- initCommissionRate()
- setCommissionRate()
- setRewardFundAllocation2()
- getMinimumBond(), setMinimumBond()
- getPRepCountConfig(), setPRepCountConfig()
- handleDoubleSignReport()
* requestUnjail() * getSlashingRates(), setSlashingRates() * initCommissionRate() * setCommissionRate() * setRewardFundAllocation2() * setMinimumBond() * getMinimumBond() * getPRepCountConfig(), setPRepCountConfig() * handleDoubleSignReport()
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 46.62% 46.57% -0.06%
==========================================
Files 394 394
Lines 61930 61930
==========================================
- Hits 28876 28844 -32
- Misses 30467 30490 +23
- Partials 2587 2596 +9 |
|
I found some outdated information in |
* Update existing predefined variables * Add some eventLogs: Slashed, TermStarted * Fix typos
…lds to PRep section in icon_chainscore_api.md
mksong76
approved these changes
Dec 8, 2023
goldworm-icon
deleted the
goldworm-update-iiss4-contents-to-icon-chainscore-api-doc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.