Implement slashingRate related APIs #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goldworm-icon
commented
Aug 3, 2023
goldworm-icon
commented
- Introduce RevisionPreIISS4(23)
- Implement setSlashingRate() and getSlashingRate()
- Refactor icmodule/penalty.go
Codecov Report
@@ Coverage Diff @@
## iiss4 #159 +/- ##
========================================
Coverage ? 45.17%
========================================
Files ? 360
Lines ? 56958
Branches ? 0
========================================
Hits ? 25732
Misses ? 28872
Partials ? 2354 |
eunsoo-icon
requested changes
Aug 4, 2023
| } | ||
| rates[name] = icmodule.Rate(value.Int64()) | ||
| } | ||
| return es.SetSlashingRates(s.newCallContext(s.cc), rates) |
…lashingRate APIs in ChainScore after RevisonPreIISS4 * setSlashingRates will supersede them
* Reinforce parameter validation * Record SlashingRateChangedV2(str,int) eventLogs
eunsoo-icon
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.