Handle invalid signature case properly

icon-project · Sep 2, 2024 · 7bf8b27 · 7bf8b27
1 parent 5d494e3
commit 7bf8b27
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/javaee/rt/src/java/foundation/icon/ee/util/Crypto.java b/javaee/rt/src/java/foundation/icon/ee/util/Crypto.java
@@ -146,7 +146,9 @@ public static byte[] aggregate(String type, byte[] prevAgg, byte[] values) {
     public static byte[] recoverKey(byte[] msgHash, byte[] signature, boolean compressed) {
         BigInteger r = BigIntegers.fromUnsignedByteArray(signature, 0, 32);
         BigInteger s = BigIntegers.fromUnsignedByteArray(signature, 32, 32);
-        return recoverFromSignature(signature[64], r, s, msgHash, compressed);
+        var k = recoverFromSignature(signature[64], r, s, msgHash, compressed);
+        require(k != null, "invalid signature");
+        return k;
     }
 
     public static byte[] getAddressBytesFromKey(byte[] pubKey) {