bdt-678: Modify messages in btpblock unit test #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
inwonkim
commented
Aug 3, 2023
inwonkim
commented
- Modify BMV to accept srcnetwork without protocol in test.(ex: 0x1.icon)
* Modify BMV to accept srcnetwork without protocol in test.(ex: 0x1.icon)
sink772
requested changes
Aug 3, 2023
| @@ -38,20 +38,20 @@ public class BTPMessageVerifierUnitTest extends TestBase { | |||
| static Score score; | |||
| static final ServiceManager sm = getServiceManager(); | |||
| static final Account owner = sm.createAccount(); | |||
| static final String SRC_NETWORK_ID = "btp://0x1.icon"; | |||
| static final String SRC_NETWORK_ID = "0x1.icon"; | |||
| static final String network = "0x1.icon"; | |||
There was a problem hiding this comment.
Please remove this line as it is a duplicate of the previous line.
sink772
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.