Fix bitwise op bug that occurs while checking if signature exists.

icon-project · Dec 29, 2023 · 00c6183 · 00c6183
1 parent 28edf40
commit 00c6183
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/bmv/bsc2/src/main/java/foundation/icon/btp/bmv/bsc2/VoteAttestation.java b/bmv/bsc2/src/main/java/foundation/icon/btp/bmv/bsc2/VoteAttestation.java
@@ -101,6 +101,7 @@ private boolean mask(int nth) {
         Context.require(nth <= 64, "Invalid voter index");
         int i = nth / 8;
         Context.require(i < VOTES_BYTES_LENGTH, "Invalid bitset access");
-        return (votes[i] >> (nth % 8) & 1) == 1;
+        Context.require(votes.length >= i + 1, "Invalid votes index");
+        return (votes[votes.length - i - 1] >> (nth % 8) & 1) == 1;
     }
 }
diff --git a/bmv/bsc2/src/test/resources/testnet.json b/bmv/bsc2/src/test/resources/testnet.json