fix: return 1 for gcd_for_slice if all elements are 0.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichi-h
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
WalkerTableBuilderif we callbuildand the sum of elements is 0 - it returns "WalkerTable that performs unweighted random sampling"But during call of
newforWalkerTableBuilder(f32) we have a division by gcd - it leads todivision by zeroerrors because it returns 0 for slice of 0. We need to return 1 for gcd if all elements are 0, so we can get "WalkerTable that performs unweighted random sampling" frombuildcall forWalkerTableBuilder(f32) where all elements are0.0