up moko permissions version 0.15.0 -> 0.18.0 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex009
reviewed
Apr 19, 2024
| @@ -21,8 +20,10 @@ actual fun BindMediaPickerEffect(mediaPickerController: MediaPickerController) { | |||
| val context: Context = LocalContext.current | |||
|
|
|||
| LaunchedEffect(mediaPickerController, lifecycleOwner, context) { | |||
| val fragmentManager: FragmentManager = (context as FragmentActivity).supportFragmentManager | |||
| val activity: FragmentActivity = checkNotNull(context as? FragmentActivity) { | |||
There was a problem hiding this comment.
can we use ComponentActivity here?
There was a problem hiding this comment.
not yet. for now we use fragmentManager for create and find FilePickerFragment, ImagePickerFragment and MediaPickerFragment and perhaps we can use ComponentActivity after change request result approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now
MediaPickerControllerinterface changed it bind method for passFragmentActivityfor new request moko permissions approach