Add block:Photos support to block:Photoset #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied block:Photo into block:Photoset to allow iteration over individual photos in the themes. This is an initial test but it seems to work so far.
|
I'll have to look at this more. Only the initial image seems have data now. [edit - more info] I should add that I am testing this on URLs that show a single post only like: http://tumblr.dev/#/theme/theme-name/url/blog.tumblr.com/post/post-#/post-slug |
|
Interesting. I took a guess and looked at how your HasTags is handled. Instead of {tag} content {/tag} it is {tag} content {/tag} and this seems to be working! Pull request coming shortly. I also added the HighRes URL as well. |
Previewing through tumblrthemr now shows iterations over photos. Also added HighRest URL outside of block:HighRestURL. It works, but not sure if that's the best way to go about it.
Found that RebloggedFrom was not showing in posts. Added that to Photoset, Photo, and Video as those are my immediate need. Will be testing.
Photosets seem to now work with NoReblog (displaying content within NoReblog) and also RebloggedFrom. The reason is I am using custom logic for local photosets and using default displays for reblogged photosets.
These are referenced here: https://groups.google.com/forum/#!msg/tumblr-themes/v3SxNAW70cU/dHCZWn7yFPYJ Specifically: They are Undocumented. {Name} Gives the "Tumblr Name" of the user {Host} Gives the "Host name" for the blog (ie, if the URL is http://foobar.tumblr.com, this generates "foobar.tumblr.com") Note that for Tumblrs with a Custom domain name, the {Host} variable will return that custom domain name. So if the Tumblr's URL is "http://www.my-awesome-tumblr.com", {Host} generates "www.my-awesome-tumblr.com" The {Name} variable always returns the actual Tumblr Name of the blog, regardless of whether it has a custom domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied block:Photo into block:Photoset to allow iteration over individual photos in the themes. This is an initial test but it seems to work so far. This allows for more flexibility than just using the photoset embed codes.