don't try to draw empty meshes in wgpu #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Feb 3, 2025
wgpu/src/lib.rs
Outdated
Comment on lines
560
to
562
| if !mesh.indices().is_empty() { | ||
| let (layer, transformation) = self.layers.current_mut(); | ||
| layer.draw_mesh(mesh, transformation); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !mesh.indices().is_empty() { | |
| let (layer, transformation) = self.layers.current_mut(); | |
| layer.draw_mesh(mesh, transformation); | |
| } | |
| if mesh.indices().is_empty() { | |
| return; | |
| } | |
| let (layer, transformation) = self.layers.current_mut(); | |
| layer.draw_mesh(mesh, transformation); |
|
Thinking about it a bit more. I think this is a check that should happen in user code. We consider empty meshes invalid. The same way trying to draw an empty quad is invalid too. Or tessellating an empty path. Or a mesh with a number of indices that is not a multiple of 3. Instead of checking every mesh, if your code can produce empty meshes, you should filter them out right there. In any case, we can add a |
|
Sure, a debug assert also sounds reasonable. At least that would make the issue more easily debuggable |
hecrj
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mesh with empty indices doesn't have anything to draw, so skip drawing it.
Giving tiny-skia empty meshes to draw works fine, however the wgpu renderer crashes horribly. This prevents that crash.
closes #2774