Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of utils/neutrino_astronomy.py #242

Merged
merged 40 commits into from
Jan 12, 2023
Merged

Review of utils/neutrino_astronomy.py #242

merged 40 commits into from
Jan 12, 2023

Conversation

mlincett
Copy link
Collaborator

@mlincett mlincett commented Jan 9, 2023

Pull request following up on #236.

Drops all the "nearest source" astronomy calculations, leaving that exercise to the user.

The calculate_astronomy() function now only calculates the integrated energy flux from the differential flux.

Although there seems to be a problem, since the functionality was used in some past analysis code, following up again in #236.

@mlincett mlincett marked this pull request as ready for review January 9, 2023 17:12
@mlincett
Copy link
Collaborator Author

The operations and outputs based on "Mean Luminosity (erg/s)" (as in "mean luminosity of the nearest source") have been removed from calculate_upper_limits() in the core.unblinding module. This function is not covered by unit tests nor it is invoked in any of the code in the repo (including analyses). I will consider moving such function to utils in a future PR, as it is not an organic part of the unblinding code.

Unless there are further comments / doubts I will proceed with the merge tomorrow.

@mlincett mlincett merged commit ea05c7d into master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants