Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEGG PMT matching #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DEGG PMT matching #14

wants to merge 1 commit into from

Conversation

BeritSchlueter
Copy link
Collaborator

  • Adding DEGG PMT matching
  • Changing typo in the in the scan functions
  • Changing on line in OMSim Hit that stricter compiler can run the code

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this change for again?

Did you check e.g. a single effective area direction if all other modules (especially DOM) still behave normally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the mDOM and the D-Egg. The change was needed because else my compiler was complaining. I can test the DOM.,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the need/reason for the change of measurement file documented somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to change it for step 4, because else the beam started in the PMT glass.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I mean if that is written down (documented) anywhere - e.g. documentation/notebooks/detection_efficiency_matching or some other suitable place. Also add a backup of the original file (from the measurement) to that, else it will be lost over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants