Properties: blur;blurColor;outlineColor; #20

MoeJaber · 2022-07-14T20:58:21Z

No description provided.

ikbendewilliam

Thank you for your PR, overal looks good, but the non-optional outlineColor makes this a breaking change while it doesn't have to be. If you can fix that, it will be a welcome addition.

ikbendewilliam · 2022-07-15T09:05:05Z

README.md

@@ -8,6 +8,7 @@ An Image cropper that is customizable
 [![MIT license](https://img.shields.io/badge/License-MIT-blue.svg)](https://lbesson.mit-license.org/)

 <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customimagecrop.gif?raw=true" alt="customcropcircle" height="320"/> <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customcropsquare.png?raw=true" alt="customcropsquare" height="320"/> <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customcropcircle.png?raw=true" alt="customcropcircle" height="320"/>
+<img src="https://github.com/MoeJaber/flutter-custom-image-crop/blob/main/example/screenshots/customimagecropblur.jpg?raw=true" alt="customcropcircle" height="320"/>


Maybe already point to https://github.com/icapps/... so we don't loose the image in the future

ikbendewilliam · 2022-07-15T09:06:26Z

lib/src/painters/dotted_path_painter.dart

@@ -5,6 +5,7 @@ class DottedCropPathPainter extends CustomPainter {
  static const _dashWidth = 10.0;
  static const _dashSpace = 5.0;
  static const _strokeWidth = 4.0;
+  Color outlineColor;


This can be final. I would also make this optional with Colors.white as fallback

ikbendewilliam · 2022-07-15T09:06:33Z

lib/src/painters/solid_path_painter.dart

@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
 /// Draw a solid path around the given path
 class SolidCropPathPainter extends CustomPainter {
  static const _strokeWidth = 4.0;
+  Color outlineColor;


This can be final. I would also make this optional with Colors.white as fallback

I would not use white, but transparant because it would break/update all current implementation to an outline implementation

The current implementation uses white

final _paint = Paint() ..color = Colors.white .... void paint(Canvas canvas, Size size) { _paint.color = outlineColor; ...

forget what I said here :D

ikbendewilliam · 2022-07-15T09:09:42Z

lib/src/painters/solid_path_painter.dart

@@ -11,14 +12,17 @@ class SolidCropPathPainter extends CustomPainter {
    ..strokeJoin = StrokeJoin.round;

  /// Draw a solid path around the given path
-  SolidCropPathPainter(this._path);
+  SolidCropPathPainter(this._path, this.outlineColor);


Like this so we know what the Color means and it's not required or breaking

SolidCropPathPainter(this._path, {this.outlineColor = Colors.white,});

ikbendewilliam · 2022-07-15T09:11:19Z

lib/src/widgets/custom_image_crop_widget.dart

+  final Color? blurColor;
+
+  /// Sets the color of the outline of the crop selection area
+  Color? outlineColor = Colors.white;


final and not nullable, but default Colors.white

vanlooverenkoen · 2022-07-15T09:18:04Z

pubspec.yaml

@@ -12,6 +12,7 @@ dependencies:
    sdk: flutter
  gesture_x_detector: ^1.0.0
  vector_math: ^2.1.0
+  blur: ^3.0.0


Do we really need this package? Isn't it possible to blur with flutter directly?

vanlooverenkoen · 2022-07-15T09:18:15Z

README.md

@@ -8,6 +8,7 @@ An Image cropper that is customizable
 [![MIT license](https://img.shields.io/badge/License-MIT-blue.svg)](https://lbesson.mit-license.org/)

 <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customimagecrop.gif?raw=true" alt="customcropcircle" height="320"/> <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customcropsquare.png?raw=true" alt="customcropsquare" height="320"/> <img src="https://github.com/icapps/flutter-custom-image-crop/blob/main/example/screenshots/customcropcircle.png?raw=true" alt="customcropcircle" height="320"/>
+<img src="https://github.com/MoeJaber/flutter-custom-image-crop/blob/main/example/screenshots/customimagecropblur.jpg?raw=true" alt="customcropcircle" height="320"/>


already link to icapps.

vanlooverenkoen · 2022-07-15T09:18:26Z

example/lib/main.dart

@@ -15,6 +15,7 @@ class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
+      debugShowCheckedModeBanner: false,


remove this

vanlooverenkoen · 2022-07-15T09:19:48Z

lib/src/painters/solid_path_painter.dart

@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
 /// Draw a solid path around the given path
 class SolidCropPathPainter extends CustomPainter {
  static const _strokeWidth = 4.0;
+  Color outlineColor;


I would not use white, but transparant because it would break/update all current implementation to an outline implementation

vanlooverenkoen · 2022-07-15T09:20:13Z

lib/src/painters/solid_path_painter.dart

@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
 /// Draw a solid path around the given path
 class SolidCropPathPainter extends CustomPainter {
  static const _strokeWidth = 4.0;
+  Color outlineColor;


I also think we should make the width configurable directly

vanlooverenkoen · 2023-06-09T11:29:03Z

Any update on this?

MoeJaber added 3 commits July 13, 2022 18:35

Properties: blur;blurColor;outlineColor;

2ae37c7

Update README.md

82d4da7

Update README.md

0eaf5bc

vanlooverenkoen requested a review from ikbendewilliam July 15, 2022 07:16

ikbendewilliam requested changes Jul 15, 2022

View reviewed changes

vanlooverenkoen suggested changes Jul 15, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properties: blur;blurColor;outlineColor; #20

Properties: blur;blurColor;outlineColor; #20

MoeJaber commented Jul 14, 2022

ikbendewilliam left a comment

ikbendewilliam Jul 15, 2022

ikbendewilliam Jul 15, 2022

ikbendewilliam Jul 15, 2022

vanlooverenkoen Jul 15, 2022

ikbendewilliam Jul 15, 2022

vanlooverenkoen Jul 15, 2022

ikbendewilliam Jul 15, 2022

ikbendewilliam Jul 15, 2022

vanlooverenkoen Jul 15, 2022

vanlooverenkoen Jul 15, 2022

vanlooverenkoen Jul 15, 2022

vanlooverenkoen Jul 15, 2022

vanlooverenkoen Jul 15, 2022

vanlooverenkoen commented Jun 9, 2023

Properties: blur;blurColor;outlineColor; #20

Are you sure you want to change the base?

Properties: blur;blurColor;outlineColor; #20

Conversation

MoeJaber commented Jul 14, 2022

ikbendewilliam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vanlooverenkoen commented Jun 9, 2023