Implement choice between different screw insert brands #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two functions screw-insert-holes and screw-insert-screw-holes whose difference was unclear. screw-insert-screw-holes creates the holes for the bottom plate only, so it was renamed to screw-insert-holes-plate.
Responsibility for creating and positioning shapes of screw insert holes was scattered across multiple methods which made it hard to maintain. In particular, dimensions of the screw insert shape had to be passed to the `screw-insert` and `screw-placement` functions which do not need this information, as they mostly do positioning work. Screw insert shapes are now created directly in `screw-insert-hole` and others. `screw-insert` is renamed to `screw-placement-common` to better reflect the changes.
Bottom plate generation in manuform.clj relied on several hacky 3D operations (micro-translations before projection operations and extruded screw hole shapes). This is replaced with 2D operations followed by a single linear_extrude. This commit also fixes the non-aligning bottom plate mentioned in ibnuda#112.
After these changes, the dome part of a screw insert shape never overlaps with the cylinder even for wild parameter choices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #110 and implements #113.
Screenshot:
Regarding backwards compatibility: when loading a JSON file produced by an older version of the generator, screw inserts will always be turned off. That's not optimal, but I think people will definitely notice missing screw inserts before printing.