Include jextract and jpackcore on all platforms #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it fixes #20661. If we are going to supply jpackcore on Windows, it needs to be in the jre/bin directory, otherwise it will be missing for anyone using the JRE. I also don't see any need to put jpackcore in the bin directory. Given we don't create the launchers on Windows |
|
This (in its current form) will not affect Windows. I see |
|
Updated to include the tools on Windows. |
|
@pshipton Any remaining concerns? |
pshipton
reviewed
Nov 28, 2024
|
Yes sorry, I made comments but never published them. |
Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
changed the title
pshipton
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-openj9/openj9#20661.