Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ dev.env
dev.op.env
.env.merged
.env.op.local
.env*.local
# mock that shouldnt change
*/mock.jwt.cookie.auth.guard.ts

# manifest files
face_expresstion_model-weights_manifest.json
Expand Down
9 changes: 9 additions & 0 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,15 @@
"verified_result": null
}
],
"apps/api/src/database/prisma.service.spec.ts": [
{
"hashed_secret": "9d4e1e23bd5b727046a9e3b4b7db57bd8d6ee684",
"is_verified": false,
"line_number": 8,
"type": "Basic Auth Credentials",
"verified_result": null
}
],
"apps/web/.env.template": [
{
"hashed_secret": "d08f88df745fa7950b104e4a707a31cfce7b5841",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,15 @@ export class MockJwtCookieAuthGuard extends AuthGuard("cookie-strategy") {
const request: RequestWithUserSession = context.switchToHttp().getRequest();

request.user = {
userId: "[email protected]",
role: UserRole.AUTHOR,
groupId: "autogen-faculty-v1-course-v1-IND-AI0103EN-v1",
assignmentId: 1,
userId: "dev-user",
role: UserRole.LEARNER,
groupId: "string",
assignmentId: 1888,
gradingCallbackRequired: false,
returnUrl: "https://skills.network",
launch_presentation_locale: "en",
};

return true;
}
}
2 changes: 1 addition & 1 deletion apps/api/src/api/Job/job-status.service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Injectable } from "@nestjs/common";
import { Job } from "@prisma/client";
import { Observable, Subject } from "rxjs";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";

@Injectable()
export class JobStatusServiceV1 {
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/Job/job.module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { HttpModule } from "@nestjs/axios";
import { Module } from "@nestjs/common";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { JobStatusServiceV1 } from "./job-status.service";

@Module({
Expand Down
16 changes: 15 additions & 1 deletion apps/api/src/api/admin/admin.controller.spec.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,27 @@
import { Test, TestingModule } from "@nestjs/testing";
import { AdminVerificationService } from "../../auth/services/admin-verification.service";
import { PrismaService } from "../../prisma.service";
import { PrismaService } from "../../database/prisma.service";
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
import { AdminController } from "./admin.controller";
import { AdminRepository } from "./admin.repository";
import { AdminService } from "./admin.service";

describe("AdminController", () => {
let controller: AdminController;
const originalDatabaseUrl = process.env.DATABASE_URL;

beforeAll(() => {
process.env.DATABASE_URL =
originalDatabaseUrl ?? "postgresql://user:pass@localhost:5432/test"; // pragma: allowlist secret
});

afterAll(() => {
if (originalDatabaseUrl) {
process.env.DATABASE_URL = originalDatabaseUrl;
} else {
delete process.env.DATABASE_URL;
}
});

beforeEach(async () => {
const mockLlmPricingService = {
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/admin/admin.module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Module } from "@nestjs/common";
import { PassportModule } from "@nestjs/passport";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { AdminAuthModule } from "../../auth/admin-auth.module";
import { AuthModule } from "../../auth/auth.module";
import { LlmModule } from "../llm/llm.module";
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/admin/admin.repository.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Injectable } from "@nestjs/common";
import { Assignment, AssignmentAttempt } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { RegradingRequestDto } from "../assignment/attempt/dto/assignment-attempt/feedback.request.dto";

@Injectable()
Expand Down
16 changes: 15 additions & 1 deletion apps/api/src/api/admin/admin.service.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
import { Test, TestingModule } from "@nestjs/testing";
import { PrismaService } from "../../prisma.service";
import { PrismaService } from "../../database/prisma.service";
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
import { AdminService } from "./admin.service";

describe("AdminService", () => {
let service: AdminService;
const originalDatabaseUrl = process.env.DATABASE_URL;

beforeAll(() => {
process.env.DATABASE_URL =
originalDatabaseUrl ?? "postgresql://user:pass@localhost:5432/test"; // pragma: allowlist secret
});

afterAll(() => {
if (originalDatabaseUrl) {
process.env.DATABASE_URL = originalDatabaseUrl;
} else {
delete process.env.DATABASE_URL;
}
});

beforeEach(async () => {
const mockLlmPricingService = {
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/admin/admin.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
UserRole,
UserSession,
} from "../../auth/interfaces/user.session.interface";
import { PrismaService } from "../../prisma.service";
import { PrismaService } from "../../database/prisma.service";
import { LLMPricingService } from "../llm/core/services/llm-pricing.service";
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
import { AdminAddAssignmentToGroupResponseDto } from "./dto/assignment/add.assignment.to.group.response.dto";
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/assignment/attempt/attempt.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
} from "@nestjs/common";
import {
Assignment,
CorrectAnswerVisibility,

Check warning on line 13 in apps/api/src/api/assignment/attempt/attempt.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'CorrectAnswerVisibility' is defined but never used
Question,
QuestionType,
QuestionVariant,
Expand All @@ -21,8 +21,8 @@
import { JsonValue } from "@prisma/client/runtime/library";
import { LearnerFileUpload } from "src/api/attempt/common/interfaces/attempt.interface";
import {
SuccessPageDataDto,

Check warning on line 24 in apps/api/src/api/assignment/attempt/attempt.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'SuccessPageDataDto' is defined but never used
SuccessPageQuestionDto,

Check warning on line 25 in apps/api/src/api/assignment/attempt/attempt.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'SuccessPageQuestionDto' is defined but never used
} from "src/api/attempt/dto/success-page-data.dto";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { PresentationQuestionEvaluateModel } from "src/api/llm/model/presentation.question.evaluate.model";
Expand All @@ -32,7 +32,7 @@
UserSession,
UserSessionRequest,
} from "../../../auth/interfaces/user.session.interface";
import { PrismaService } from "../../../prisma.service";
import { PrismaService } from "../../../database/prisma.service";
import { QuestionAnswerContext } from "../../llm/model/base.question.evaluate.model";
import { FileUploadQuestionEvaluateModel } from "../../llm/model/file.based.question.evaluate.model";
import { TextBasedQuestionEvaluateModel } from "../../llm/model/text.based.question.evaluate.model";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
UserRole,
UserSessionRequest,
} from "../../../../auth/interfaces/user.session.interface";
import { PrismaService } from "../../../../prisma.service";
import { PrismaService } from "../../../../database/prisma.service";

@Injectable()
export class AssignmentAttemptAccessControlGuard implements CanActivate {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
} from "@nestjs/common";
import { Reflector } from "@nestjs/core";
import { UserSessionRequest } from "src/auth/interfaces/user.session.interface";
import { PrismaService } from "../../../prisma.service";
import { PrismaService } from "../../../database/prisma.service";

@Injectable()
export class AssignmentAccessControlGuard implements CanActivate {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from "@nestjs/common";
import { Reflector } from "@nestjs/core";
import { UserSessionRequest } from "src/auth/interfaces/user.session.interface";
import { PrismaService } from "../../../../prisma.service";
import { PrismaService } from "../../../../database/prisma.service";

@Injectable()
export class AssignmentQuestionAccessControlGuard implements CanActivate {
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/api/assignment/question/question.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Prisma } from "@prisma/client";
import { WINSTON_MODULE_PROVIDER } from "nest-winston";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { Logger } from "winston";
import { PrismaService } from "../../../prisma.service";
import { PrismaService } from "../../../database/prisma.service";
import { LearnerLiveRecordingFeedback } from "../attempt/dto/assignment-attempt/types";
import {
Choice,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
UserRole,
UserSession,
} from "src/auth/interfaces/user.session.interface";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { Logger } from "winston";
import {
getAllLanguageCodes,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
UserSessionRequest,
} from "src/auth/interfaces/user.session.interface";
import { Roles } from "src/auth/role/roles.global.guard";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { Logger } from "winston";
import { ReportRequestDTO } from "../../attempt/dto/assignment-attempt/post.assignment.report.dto";
import { ASSIGNMENT_SCHEMA_URL } from "../../constants";
Expand All @@ -61,7 +61,7 @@
import { QuestionService } from "../services/question.service";
import { ReportService } from "../services/report.repository";

interface AdminSessionRequest extends Request {

Check warning on line 64 in apps/api/src/api/assignment/v2/controllers/assignment.controller.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'AdminSessionRequest' is defined but never used
adminSession: {
email: string;
role: UserRole;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Module } from "@nestjs/common";
import { AdminService } from "src/api/admin/admin.service";
import { LlmModule } from "src/api/llm/llm.module";
import { AdminVerificationService } from "src/auth/services/admin-verification.service";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { AssignmentControllerV2 } from "../controllers/assignment.controller";
import { DraftManagementController } from "../controllers/draft-management.controller";
import { VersionManagementController } from "../controllers/version-management.controller";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { Assignment, Question, QuestionVariant } from "@prisma/client";
import {
UserRole,
UserSession,
} from "../../../../auth/interfaces/user.session.interface";
import { PrismaService } from "../../../../prisma.service";
} from "src/auth/interfaces/user.session.interface";
import { PrismaService } from "src/database/prisma.service";
import {
AssignmentResponseDto,
GetAssignmentResponseDto,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable unicorn/no-null */
import { Injectable, Logger } from "@nestjs/common";
import { Prisma, Question, QuestionVariant } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
Choice,
QuestionDto,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable unicorn/no-null */
import { Injectable, Logger } from "@nestjs/common";
import { Prisma, QuestionVariant } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
Choice,
ScoringDto,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { NotFoundException } from "@nestjs/common";
import { Test, TestingModule } from "@nestjs/testing";
import { WINSTON_MODULE_PROVIDER } from "nest-winston";
import { UserRole } from "../../../../../auth/interfaces/user.session.interface";
import { PrismaService } from "../../../../../prisma.service";
import { PrismaService } from "../../../../../database/prisma.service";
import { VersionManagementService } from "../version-management.service";

describe("VersionManagementService", () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Inject, Injectable } from "@nestjs/common";
import { WINSTON_MODULE_PROVIDER } from "nest-winston";
import { UserSession } from "src/auth/interfaces/user.session.interface";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { Logger } from "winston";
import { BaseAssignmentResponseDto } from "../../dto/base.assignment.response.dto";
import {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
UserSession,
} from "src/auth/interfaces/user.session.interface";
import { Logger } from "winston";
import { PrismaService } from "../../../../prisma.service";
import { PrismaService } from "../../../../database/prisma.service";

export interface SaveDraftDto {
draftName?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { QuestionType } from "@prisma/client";
import { WINSTON_MODULE_PROVIDER } from "nest-winston";
import { RubricScore } from "src/api/llm/model/file.based.question.response.model";
import { Logger } from "winston";
import { PrismaService } from "../../../../prisma.service";
import { PrismaService } from "../../../../database/prisma.service";
import {
CriteriaDto,
ScoringDto,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
switchMap,
takeWhile,
} from "rxjs";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";

interface JobStatus {
status: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import { ResponseType } from "@prisma/client";
import { AssignmentTypeEnum } from "src/api/llm/features/question-generation/services/question-generation.service";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import { BaseAssignmentResponseDto } from "../../dto/base.assignment.response.dto";
import {
EnhancedQuestionsToGenerate,
Expand Down Expand Up @@ -102,7 +102,7 @@
questions: QuestionDto[],
jobId?: number,
progressCallback?: (progress: number) => Promise<void>,
forceTranslation = false,

Check warning on line 105 in apps/api/src/api/assignment/v2/services/question.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'forceTranslation' is assigned a value but never used
): Promise<void> {
const INITIAL_SETUP_RANGE = { start: 0, end: 10 };
const QUESTION_PROCESSING_RANGE = { start: 10, end: 90 };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
UnprocessableEntityException,
} from "@nestjs/common";
import { ReportType } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";

@Injectable()
export class ReportService {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { Prisma } from "@prisma/client";
import Bottleneck from "bottleneck";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
getAllLanguageCodes,
getLanguageNameFromCode,
Expand Down Expand Up @@ -120,7 +120,7 @@
items: T[],
batchProcessor: (item: T) => Promise<boolean>,
batchSize = this.MAX_BATCH_SIZE,
_concurrencyLimit = this.CONCURRENCY_LIMIT,

Check warning on line 123 in apps/api/src/api/assignment/v2/services/translation.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'_concurrencyLimit' is assigned a value but never used
): Promise<BatchProcessResult> {
const results: BatchProcessResult = { success: 0, failure: 0, dropped: 0 };
const chunks: T[][] = [];
Expand Down Expand Up @@ -775,7 +775,7 @@
operationName: string,
translationFunction: () => Promise<T>,
maxAttempts = this.MAX_RETRY_ATTEMPTS,
_jobId?: number,

Check warning on line 778 in apps/api/src/api/assignment/v2/services/translation.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'_jobId' is defined but never used
): Promise<T> {
let attempts = 0;
const operationId = `${operationName}-${Date.now()}`;
Expand Down Expand Up @@ -843,7 +843,7 @@
/**
* Handle stuck operations by resetting limiter if needed
*/
private handleStuckOperation(_operationName: string): void {

Check warning on line 846 in apps/api/src/api/assignment/v2/services/translation.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'_operationName' is defined but never used
this.operationStats.consecutiveFailures++;
this.operationStats.lastFailureTime = Date.now();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
UserSession,
} from "src/auth/interfaces/user.session.interface";
import { Logger } from "winston";
import { PrismaService } from "../../../../prisma.service";
import { PrismaService } from "../../../../database/prisma.service";
import { QuestionDto } from "../../dto/update.questions.request.dto";
import { assign } from "nodemailer/lib/shared";

Check warning on line 27 in apps/api/src/api/assignment/v2/services/version-management.service.ts

View workflow job for this annotation

GitHub Actions / Lint & Test - api

'assign' is defined but never used

export interface CreateVersionDto {
versionNumber?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Test, TestingModule } from "@nestjs/testing";
import { QuestionType } from "@prisma/client";
import { GetAssignmentResponseDto } from "src/api/assignment/dto/get.assignment.response.dto";
import { ScoringDto } from "src/api/assignment/dto/update.questions.request.dto";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockAssignment,
sampleAuthorSession,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
QuestionDto,
ScoringDto,
} from "src/api/assignment/dto/update.questions.request.dto";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockPrismaService,
createMockQuestion,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from "@nestjs/common";
import { Test, TestingModule } from "@nestjs/testing";
import { ReportType } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockAssignment,
createMockReport,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import { Test, TestingModule } from "@nestjs/testing";
import { Prisma, VariantType } from "@prisma/client";
import { VariantDto } from "src/api/assignment/dto/update.questions.request.dto";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockPrismaService,
createMockQuestionVariant,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from "src/api/assignment/dto/update.questions.request.dto";
import { QuestionService } from "src/api/assignment/v2/services/question.service";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockAssignmentRepository,
createMockAssignmentResponseDto,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/* eslint-disable unicorn/no-null */
import { Test, TestingModule } from "@nestjs/testing";
import { firstValueFrom } from "rxjs";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockJob,
createMockPrismaService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
VariantDto,
} from "src/api/assignment/dto/update.questions.request.dto";
import { LlmFacadeService } from "src/api/llm/llm-facade.service";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockJob,
createMockJobStatusService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from "@nestjs/common";
import { Test, TestingModule } from "@nestjs/testing";
import { ReportType } from "@prisma/client";
import { PrismaService } from "src/prisma.service";
import { PrismaService } from "src/database/prisma.service";
import {
createMockAssignment,
createMockPrismaService,
Expand Down
Loading
Loading