IBX-9678: JsonSerializableNormalizer return type mismatch causing 500 error #160
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
barw4
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Maybe it's an overkill but it would be great to have an integration test with a bit more complicated case, like object that uses MoneyObjecy, please see https://github.com/ibexa/rest/blob/main/tests/integration/Serializer/SerializerTest.php
Maybe you could add another case there and use TestDataObject with MoneyObject.
|
|
||
| namespace Ibexa\Tests\Rest\Output; | ||
|
|
||
| class MoneyObject implements \JsonSerializable |
There was a problem hiding this comment.
Suggested change
| class MoneyObject implements \JsonSerializable | |
| final class MoneyObject implements \JsonSerializable |
| * @copyright Copyright (C) Ibexa AS. All rights reserved. | ||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Suggested change
| declare(strict_types=1); | |
konradoboza
reviewed
Mar 13, 2025
| use Ibexa\Tests\Rest\Output\MoneyObject; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class ArrayNormalizerTest extends TestCase |
There was a problem hiding this comment.
Suggested change
| class ArrayNormalizerTest extends TestCase | |
| final class ArrayNormalizerTest extends TestCase |
| /** | ||
| * @copyright Copyright (C) Ibexa AS. All rights reserved. | ||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| */ | |
| declare(strict_types=1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
JsonSerializableNormalizer is hint typed to return string but we also normalize objects like
Money/Moneythat return an array. If we try to create an order through API on latest Ibexa 5.0 the order would get created but on the return we would get an 500 error. I have changed the hint type to cover array as well.I have also added a test to cover this scenario. Rest package doest not uses
moneyphp/moneypackage anywhere directly so instead of adding a dependency I have created a dummy object with minimal implementation to simulate the behavior of real Money object that returns an array.Discovered while testing https://github.com/ibexa/order-management/pull/137 on 5.0
For QA:
Documentation: