Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibexa/test-fixtures] Fixed configuration recipes #160

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

alongosz
Copy link
Member

🎫 Issue n/a

Related PRs:

Description:

Current recipes produce config/services.yaml as follows:

imports:
  - { resource: packages/test_fixtures/commerce.yaml }:
  - { resource: packages/test_fixtures/experience.yaml }:
  - { resource: packages/test_fixtures/headless.yaml }:

That trailing colon causes a fatal error when clearing Symfony cache.

For QA:

Install test-fixtures to observe the issue.

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-160

before executing the recipes.

@alongosz alongosz requested review from mnocon, tomaszszopinski and a team February 21, 2025 14:07
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I wonder why I did it that way 😄

@alongosz
Copy link
Member Author

Nice catch, I wonder why I did it that way 😄

@mnocon My thing was, how was it possible that was working. Well, seems for Symfony 5 that syntax issue is fine 🤣

@adamwojs adamwojs merged commit dee2f4d into master Feb 21, 2025
4 checks passed
@adamwojs adamwojs deleted the fix-test-fixtures-config branch February 21, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants